incubator-tuweni icon indicating copy to clipboard operation
incubator-tuweni copied to clipboard

Published 20 hours ago • verified publisher icon apache

findLargestTotalDifficulty nits

Open atoulme opened this issue 3 years ago • 4 comments

Make the javadoc better Don't return Hash?, return Hash instead.

atoulme avatar Jun 07 '21 20:06 atoulme

@atoulme can i work on this, can you also specify the list of classes the changes that are to be addressed to.

SivaTharun avatar Jun 08 '21 06:06 SivaTharun

Absolutely. The class to change is here: https://github.com/apache/incubator-tuweni/blob/257e37a1a8439197412fbc5c8e74d0fa5dcb420a/eth-repository/src/main/kotlin/org/apache/tuweni/eth/repository/BlockchainIndex.kt#L148

atoulme avatar Jun 08 '21 07:06 atoulme

Hi Antoine, I was looking at this and thinking of working on this. Not sure what you would like for desired behavior if the scoreDocs is empty? Looking at the other functions, should I return List of < Hash > instead?

sudo-update avatar Jun 27 '21 16:06 sudo-update

I am not sure I understand. Open a pull request for review please.

atoulme avatar Jun 27 '21 17:06 atoulme