incubator-seata
incubator-seata copied to clipboard
optimize: Optimize RM/TM client reconnect
- [x] I have read the CONTRIBUTING.md guidelines.
- [x] I have registered the PR changes.
Ⅰ. Describe what this PR did
Optimized RM/TM client reconnect logic to prevent duplicate timer creation .
Ⅱ. Does this pull request fix one issue?
fixes https://github.com/apache/incubator-seata/issues/5338
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
Codecov Report
:x: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 71.09%. Comparing base (c13207c) to head (0f28ad7).
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...ta/core/rpc/netty/AbstractNettyRemotingClient.java | 96.77% | 0 Missing and 1 partial :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## 2.x #7783 +/- ##
============================================
+ Coverage 71.07% 71.09% +0.01%
Complexity 797 797
============================================
Files 1294 1294
Lines 49528 49543 +15
Branches 5873 5876 +3
============================================
+ Hits 35202 35221 +19
+ Misses 11418 11415 -3
+ Partials 2908 2907 -1
| Files with missing lines | Coverage Δ | |
|---|---|---|
| ...ta/core/rpc/netty/AbstractNettyRemotingClient.java | 82.89% <96.77%> (+2.64%) |
:arrow_up: |
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
I've addressed the resource leak issue by removing the static modifier from the reconnect timer and related resources.Am I on the right track?Let me know if further adjustments are needed!If you are convenient,please take a look❤️. @maple525866