incubator-seata icon indicating copy to clipboard operation
incubator-seata copied to clipboard

feature: support raft configuration center

Open LegGasai opened this issue 1 year ago • 2 comments

  • [ ] I have registered the PR changes.

Ⅰ. Describe what this PR did

support raft configuration center

Ⅱ. Does this pull request fix one issue?

fixes #6829

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

设计文档(Design doc):https://c05j6bovqhh.feishu.cn/docx/JGEKd5QSDocc4bxz6PrcgLXUnIb 使用文档(Usage doc):https://c05j6bovqhh.feishu.cn/docx/XM4Gdp3qPoDTwCxA1zbcvmY5n4f

LegGasai avatar Sep 08 '24 12:09 LegGasai

Please fix this

You have 2 PMD violations. For more details see: ~/incubator-seata/incubator-seata/config/seata-config-core/target/pmd.xml

xingfudeshi avatar Sep 09 '24 03:09 xingfudeshi

Codecov Report

Attention: Patch coverage is 57.56757% with 628 lines in your changes missing coverage. Please review.

Project coverage is 52.91%. Comparing base (ab4f44e) to head (c9f796a). Report is 5 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ta/server/cluster/raft/RaftConfigStateMachine.java 43.51% 109 Missing and 13 partials :warning:
...che/seata/server/controller/ClusterController.java 34.24% 93 Missing and 3 partials :warning:
...onfig/store/rocksdb/RocksDBConfigStoreManager.java 74.84% 65 Missing and 14 partials :warning:
...r/cluster/manager/ClusterConfigWatcherManager.java 25.00% 31 Missing and 2 partials :warning:
...a/server/cluster/raft/RaftConfigServerManager.java 71.17% 21 Missing and 11 partials :warning:
...uster/raft/snapshot/config/ConfigSnapshotFile.java 21.62% 29 Missing :warning:
...ache/seata/server/cluster/watch/ConfigWatcher.java 0.00% 26 Missing :warning:
...hot/metadata/ConfigLeaderMetadataSnapshotFile.java 17.24% 24 Missing :warning:
...er/raft/execute/config/ConfigOperationExecute.java 66.07% 9 Missing and 10 partials :warning:
...a/server/cluster/raft/util/RaftConfigTaskUtil.java 28.00% 15 Missing and 3 partials :warning:
... and 27 more
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6830      +/-   ##
============================================
+ Coverage     52.65%   52.91%   +0.26%     
- Complexity     6555     6821     +266     
============================================
  Files          1122     1153      +31     
  Lines         39862    41336    +1474     
  Branches       4668     4801     +133     
============================================
+ Hits          20989    21875     +886     
- Misses        16875    17384     +509     
- Partials       1998     2077      +79     
Files with missing lines Coverage Δ
...ava/org/apache/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...c/main/java/org/apache/seata/common/Constants.java 100.00% <ø> (ø)
...in/java/org/apache/seata/common/DefaultValues.java 0.00% <ø> (ø)
...java/org/apache/seata/common/util/NumberUtils.java 66.66% <100.00%> (+23.80%) :arrow_up:
.../main/java/org/apache/seata/config/ConfigType.java 100.00% <100.00%> (ø)
.../apache/seata/config/ConfigurationChangeEvent.java 96.55% <100.00%> (+0.25%) :arrow_up:
...toconfigure/SeataCoreEnvironmentPostProcessor.java 96.87% <100.00%> (+0.20%) :arrow_up:
...ta/spring/boot/autoconfigure/StarterConstants.java 100.00% <ø> (ø)
.../src/main/java/org/apache/seata/server/Server.java 73.52% <100.00%> (+0.80%) :arrow_up:
...t/execute/config/AbstractRaftConfigMsgExecute.java 100.00% <100.00%> (ø)
... and 40 more

... and 10 files with indirect coverage changes

codecov[bot] avatar Sep 10 '24 16:09 codecov[bot]

This PR will be merged in summer-code-raft-config-center branch

xingfudeshi avatar Oct 27 '24 05:10 xingfudeshi