incubator-seata icon indicating copy to clipboard operation
incubator-seata copied to clipboard

test:Increase [integration-tx-api] module test case coverage

Open azatyamanaev opened this issue 9 months ago • 9 comments

  • [x] I have registered the PR changes.

Ⅰ. Describe what this PR did

increase test case coverage of [integration-tx-api] module

Ⅱ. Does this pull request fix one issue?

fixes #6507

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

azatyamanaev avatar May 12 '24 08:05 azatyamanaev

Pls register this PR in https://github.com/apache/incubator-seata/tree/2.x/changes

xingfudeshi avatar May 15 '24 09:05 xingfudeshi

Pls register this PR in https://github.com/apache/incubator-seata/tree/2.x/changes

@xingfudeshi Done

azatyamanaev avatar May 16 '24 13:05 azatyamanaev

@xingfudeshi Can you resolve merge conflict?

azatyamanaev avatar May 20 '24 10:05 azatyamanaev

@xingfudeshi Can you resolve merge conflict?

Yes.The current version is being released.I'll resolve conflicts after the release.

xingfudeshi avatar May 20 '24 10:05 xingfudeshi

@xingfudeshi Can you resolve merge conflict?

Yes.The current version is being released.I'll resolve conflicts after the release.

How long does it usually take?

azatyamanaev avatar May 20 '24 10:05 azatyamanaev

@xingfudeshi Can you resolve merge conflict?

Yes.The current version is being released.I'll resolve conflicts after the release.

How long does it usually take?

It won’t take long. After version 2.1 is released, I will start addressing the conflicting files in this PR.

xingfudeshi avatar May 21 '24 12:05 xingfudeshi

please resolve the conflict

I can't, I don't have write access to repository. Or should I rebase my branch?

azatyamanaev avatar Jun 13 '24 09:06 azatyamanaev

please resolve the conflict

I can't, I don't have write access to repository. Or should I rebase my branch? you can merge the 2.x branch to your branch,and resolve the confict.

lightClouds917 avatar Jun 24 '24 06:06 lightClouds917

I've fixed the conflicts for you.

justinmclean avatar Jun 25 '24 06:06 justinmclean

我修复了codecov没有report成功的问题,现在让我们看看目前的单测覆盖度是多少 I've fixed the issue with Codecov not reporting successfully. Now, let's see what the current test coverage percentage is.

funky-eyes avatar Jul 05 '24 09:07 funky-eyes

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 50.47%. Comparing base (20cd962) to head (3ebc46d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6533      +/-   ##
============================================
+ Coverage     50.02%   50.47%   +0.44%     
- Complexity     5734     5830      +96     
============================================
  Files          1051     1051              
  Lines         36340    36340              
  Branches       4321     4319       -2     
============================================
+ Hits          18179    18341     +162     
+ Misses        16365    16183     -182     
- Partials       1796     1816      +20     
Files Coverage Δ
...ta/integration/tx/api/remoting/TwoPhaseResult.java 100.00% <100.00%> (+100.00%) :arrow_up:

... and 14 files with indirect coverage changes

codecov-commenter avatar Jul 05 '24 10:07 codecov-commenter