incubator-seata icon indicating copy to clipboard operation
incubator-seata copied to clipboard

saga mode replay context lost start, issue 5682 reopen !!

Open gou60 opened this issue 1 year ago • 5 comments

Ⅰ. Issue Description

  • [#5682] 修复saga模式下replay context丢失startParams问题 reopen!

Ⅱ. Describe what happened

https://github.com/apache/incubator-seata/blob/2.x/saga/seata-saga-engine/src/main/java/io/seata/saga/engine/impl/ProcessCtrlStateMachineEngine.java

protected Map<String, Object> replayContextVariables(StateMachineInstance stateMachineInstance) {
    Map<String, Object> contextVariables = new HashMap<>();
    **if (stateMachineInstance.getStartParams() == null) {**
        contextVariables.putAll(stateMachineInstance.getStartParams());
    }

Ⅲ. Describe what you expected to happen

https://github.com/apache/incubator-seata/blob/1.8.0/saga/seata-saga-engine/src/main/java/io/seata/saga/engine/impl/ProcessCtrlStateMachineEngine.java

protected Map<String, Object> replayContextVariables(StateMachineInstance stateMachineInstance) {
    Map<String, Object> contextVariables = new HashMap<>();
    **if (stateMachineInstance.getStartParams() != null) {**
        contextVariables.putAll(stateMachineInstance.getStartParams());
    }

Ⅳ. How to reproduce it (as minimally and precisely as possible)

Ⅴ. Anything else we need to know?

Ⅵ. Environment:

gou60 avatar Jan 12 '24 06:01 gou60

@wt-better Please help with this question

funky-eyes avatar Jan 15 '24 02:01 funky-eyes

What version of seata-client are you using?

funky-eyes avatar Jan 15 '24 02:01 funky-eyes

this issue have fixed on 1.8, but not 2.x, I will fixed it on 2.x later.

wt-better avatar Jan 15 '24 03:01 wt-better

@wt-better I suggest including it in the milestone for version 2.1.0.

slievrly avatar Jan 17 '24 03:01 slievrly

@wt-better Is there any progress information here ?

slievrly avatar Feb 16 '24 13:02 slievrly