incubator-seata icon indicating copy to clipboard operation
incubator-seata copied to clipboard

optimize: optimize read of storage configuration

Open slievrly opened this issue 2 years ago • 1 comments

Signed-off-by: slievrly [email protected]

  • [x] I have registered the PR changes.

Ⅰ. Describe what this PR did

optimize read of storage configuration

  1. ParameterParser only responsible for startup parameters
  2. storeMode, sessionMode, lockMode aggregated into StoreConfig, to avoid using getConfig everywhere.
  3. storeMode, sessionMode, lockMode ignore case.
  4. resolved not recognized license by SW-eyes

Ⅱ. Does this pull request fix one issue?

fixes #4916 #4923 #4937

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

slievrly avatar Sep 15 '22 06:09 slievrly

Codecov Report

Merging #4936 (172e3af) into develop (141d855) will increase coverage by 0.32%. The diff coverage is 53.92%.

:exclamation: Current head 172e3af differs from pull request most recent head 2e616d6. Consider uploading reports for the commit 2e616d6 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4936      +/-   ##
=============================================
+ Coverage      48.73%   49.05%   +0.32%     
- Complexity      4081     4092      +11     
=============================================
  Files            736      734       -2     
  Lines          25820    25851      +31     
  Branches        3184     3190       +6     
=============================================
+ Hits           12583    12681      +98     
+ Misses         11905    11816      -89     
- Partials        1332     1354      +22     
Impacted Files Coverage Δ
...in/java/io/seata/server/session/SessionHelper.java 65.95% <0.00%> (+0.33%) :arrow_up:
...in/java/io/seata/server/session/SessionHolder.java 48.20% <31.81%> (ø)
...src/main/java/io/seata/server/ParameterParser.java 66.66% <33.33%> (+0.59%) :arrow_up:
...ava/io/seata/server/lock/LockerManagerFactory.java 56.25% <50.00%> (+20.95%) :arrow_up:
...c/main/java/io/seata/server/store/StoreConfig.java 62.16% <60.29%> (-21.18%) :arrow_down:
server/src/main/java/io/seata/server/Server.java 80.00% <100.00%> (-0.77%) :arrow_down:
...ava/io/seata/server/ServerApplicationListener.java 43.18% <100.00%> (-2.48%) :arrow_down:
...va/io/seata/server/console/vo/GlobalSessionVO.java 22.05% <0.00%> (-33.83%) :arrow_down:
...java/io/seata/server/storage/SessionConverter.java 80.00% <0.00%> (-9.10%) :arrow_down:
...rage/redis/store/RedisTransactionStoreManager.java 63.17% <0.00%> (-3.97%) :arrow_down:
... and 12 more

codecov-commenter avatar Sep 15 '22 10:09 codecov-commenter

LGTM

robynron avatar Sep 26 '22 13:09 robynron