incubator-seata
incubator-seata copied to clipboard
feature: support tencent polaris discovery
- [ ] I have registered the PR changes.
Ⅰ. Describe what this PR did
- Add Tencent Polaris Registry (Configuration & Service Discovery) support for Seata framework.
Ⅱ. Does this pull request fix one issue?
#4867.
Ⅲ. Why don't you add test cases (unit test/integration test)?
None.
Ⅳ. Describe how to verify it
A question: How is the Seata framework implemented when doing integration testing ?
Ⅴ. Special notes for reviews
None.
This pull request introduces 2 alerts when merging d273ceee966af2083d0c648e5d0121dd7ce5841f into 8ec5ccd3af424a818335fd7e00e7eb937de58675 - view on LGTM.com
new alerts:
- 2 for `TrustManager` that accepts all certificates
@misselvexu Thank you very much for your contribution, I will review this PR later.
add configuration item on follow files(used for client): https://github.com/seata/seata/tree/develop/script/client/spring
some check style not pass:
@slievrly How should I conduct integration testing? Is there any relevant case ?
some check style not pass:
i will fix this issue later。
@slievrly How should I conduct integration testing? Is there any relevant case ?
Currently, there is no integration test related to registration and configuration center. seata-test
module is used for integration testing, but this module will be reconstructed into integration testing based on testcontainers. At present, I think we can conduct mock test based on the third-party component itself.
Codecov Report
Merging #4894 (3fd571f) into develop (bf99018) will decrease coverage by
0.09%
. The diff coverage is16.09%
.
@@ Coverage Diff @@
## develop #4894 +/- ##
=============================================
- Coverage 48.95% 48.86% -0.10%
- Complexity 4168 4169 +1
=============================================
Files 741 744 +3
Lines 26521 26608 +87
Branches 3294 3294
=============================================
+ Hits 12984 13002 +18
- Misses 12129 12202 +73
+ Partials 1408 1404 -4
Impacted Files | Coverage Δ | |
---|---|---|
...c/main/java/io/seata/common/util/JacksonUtils.java | 0.00% <0.00%> (ø) |
|
...java/io/seata/discovery/registry/RegistryType.java | 0.00% <0.00%> (ø) |
|
...ta/spring/boot/autoconfigure/StarterConstants.java | 100.00% <ø> (ø) |
|
...ure/properties/config/ConfigPolarisProperties.java | 19.23% <19.23%> (ø) |
|
...properties/registry/RegistryPolarisProperties.java | 22.22% <22.22%> (ø) |
|
...core/src/main/java/io/seata/config/ConfigType.java | 78.57% <100.00%> (+1.64%) |
:arrow_up: |
...toconfigure/SeataCoreEnvironmentPostProcessor.java | 96.66% <100.00%> (+0.23%) |
:arrow_up: |
.../java/io/seata/spring/util/TCCBeanParserUtils.java | 30.64% <0.00%> (-1.62%) |
:arrow_down: |
...o/seata/server/coordinator/DefaultCoordinator.java | 47.95% <0.00%> (-0.82%) |
:arrow_down: |
...in/java/io/seata/server/session/GlobalSession.java | 78.68% <0.00%> (ø) |
|
... and 3 more |
This pull request introduces 2 alerts when merging 569439d354dd6c6f9dffcd167d3a75dcbeb7b13d into 8ec5ccd3af424a818335fd7e00e7eb937de58675 - view on LGTM.com
new alerts:
- 2 for `TrustManager` that accepts all certificates
嗨 大概多久可以合并 很期待
嗨 大概多久可以合并 很期待
1.6发版后开始review
嗨 大概多久可以合并 很期待
1.6发版后开始review
好的
2.0.0没有合并吗 review进展到什么程度了啊
Due to code conflicts and age, if you are still interested in participating in the community, please resubmit this pr to the 2.x branch after resolving the conflict. 由于代码冲突以及年代久远,如果你还有兴趣参与到社区,请解决完冲突后重新请提交这份pr至2.x分支中
Due to code conflicts and age, if you are still interested in participating in the community, please resubmit this pr to the 2.x branch after resolving the conflict. 由于代码冲突以及年代久远,如果你还有兴趣参与到社区,请解决完冲突后重新请提交这份pr至2.x分支中
After optimize the latest code, am I reapplying to re-open this PR?