incubator-seata icon indicating copy to clipboard operation
incubator-seata copied to clipboard

optimize : optimize logs when RM's commit return an exception and returns false

Open Bughue opened this issue 2 years ago • 1 comments

  • [ ] I have registered the PR changes.

Ⅰ. Describe what this PR did

TC在 RM的commit遇到异常和返回false时的行为不一致,容易发生误解,这个pr只对日志进行优化

Ⅱ. Does this pull request fix one issue?

fixes https://github.com/seata/seata/issues/4879

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Bughue avatar Aug 23 '22 03:08 Bughue

Codecov Report

Merging #4880 (315b511) into 2.x (12eabb1) will increase coverage by 0.05%. The diff coverage is 75.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #4880      +/-   ##
============================================
+ Coverage     48.50%   48.55%   +0.05%     
- Complexity     4188     4194       +6     
============================================
  Files           764      764              
  Lines         26876    26877       +1     
  Branches       3357     3358       +1     
============================================
+ Hits          13036    13051      +15     
+ Misses        12453    12436      -17     
- Partials       1387     1390       +3     
Impacted Files Coverage Δ
.../java/io/seata/server/coordinator/DefaultCore.java 53.29% <75.00%> (+5.70%) :arrow_up:
...in/java/io/seata/server/session/GlobalSession.java 70.30% <0.00%> (+0.37%) :arrow_up:
...erver/storage/file/session/FileSessionManager.java 49.68% <0.00%> (+0.63%) :arrow_up:
...in/java/io/seata/server/session/BranchSession.java 79.28% <0.00%> (+0.71%) :arrow_up:
...o/seata/server/session/AbstractSessionManager.java 65.21% <0.00%> (+2.89%) :arrow_up:

codecov-commenter avatar Aug 23 '22 03:08 codecov-commenter

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 12 '22 13:12 CLAassistant