incubator-seata icon indicating copy to clipboard operation
incubator-seata copied to clipboard

support for observing metrics collected on seata client side

Open robynron opened this issue 3 years ago • 2 comments

  • [x] I have registered the PR changes.

Ⅰ. Describe what this PR did

Improved the monitoring of various data on the Seata Client side. Help users effectively monitor the execution process and identify possible problems.

Ⅱ. Does this pull request fix one issue?

fixes #4637

Ⅲ. Why don't you add test cases (unit test/integration test)?

I'll add later.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

robynron avatar Aug 22 '22 11:08 robynron

This pull request introduces 7 alerts when merging 77ad52705c08df47cec589ee5d756a8965ffd6c7 into 06c2a50473fd59deefd6cb42d01ffd095eef20a7 - view on LGTM.com

new alerts:

  • 7 for Boxed variable is never null

lgtm-com[bot] avatar Aug 23 '22 04:08 lgtm-com[bot]

Codecov Report

Merging #4878 (e44f6fe) into develop (06c2a50) will decrease coverage by 0.72%. The diff coverage is 43.20%.

:exclamation: Current head e44f6fe differs from pull request most recent head 3511fda. Consider uploading reports for the commit 3511fda to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4878      +/-   ##
=============================================
- Coverage      49.23%   48.50%   -0.73%     
+ Complexity      4117     4084      -33     
=============================================
  Files            737      740       +3     
  Lines          25827    26757     +930     
  Branches        3193     3191       -2     
=============================================
+ Hits           12715    12979     +264     
- Misses         11764    12433     +669     
+ Partials        1348     1345       -3     
Impacted Files Coverage Δ
...c/main/java/io/seata/core/context/RootContext.java 44.61% <0.00%> (-2.16%) :arrow_down:
...src/main/java/io/seata/core/event/BranchEvent.java 0.00% <0.00%> (ø)
...va/io/seata/core/event/GlobalTransactionEvent.java 0.00% <0.00%> (ø)
.../main/java/io/seata/rm/datasource/AsyncWorker.java 40.62% <0.00%> (-4.21%) :arrow_down:
...java/io/seata/rm/datasource/DataSourceManager.java 22.22% <0.00%> (-2.17%) :arrow_down:
...m/datasource/undo/oracle/OracleUndoLogManager.java 10.25% <0.00%> (-1.51%) :arrow_down:
...urce/undo/postgresql/PostgresqlUndoLogManager.java 7.14% <0.00%> (-0.97%) :arrow_down:
...configure/SeataServerEnvironmentPostProcessor.java 0.00% <ø> (ø)
...java/io/seata/server/metrics/MetricsPublisher.java 93.75% <ø> (ø)
...src/main/java/io/seata/rm/tcc/TCCFenceHandler.java 0.00% <0.00%> (ø)
... and 23 more

codecov-commenter avatar Aug 29 '22 04:08 codecov-commenter

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 12 '22 13:12 CLAassistant

是不是要关联下 https://github.com/seata/seata/tree/develop/metrics#readme

Bughue avatar May 16 '23 07:05 Bughue

Due to code conflicts and age, if you are still interested in participating in the community, please resubmit this pr to the 2.x branch after resolving the conflict. 由于代码冲突以及年代久远,如果你还有兴趣参与到社区,请解决完冲突后重新请提交这份pr至2.x分支中

funky-eyes avatar Nov 28 '23 05:11 funky-eyes

好的,我后面基于2.x分支重新弄一下

robynron avatar Nov 28 '23 06:11 robynron