incubator-seata icon indicating copy to clipboard operation
incubator-seata copied to clipboard

[Summer code 2022] 控制台配置项页面管理

Open Yzhiqiang opened this issue 2 years ago • 5 comments

  • [ ] I have registered the PR changes.

Ⅰ. Describe what this PR did

1.编写修改配置的后端接口 2.编写前台修改配置界面

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

前端修改配置以后,提交请求给后端,后端修改配置,会触发该监听器。

Ⅴ. Special notes for reviews

Yzhiqiang avatar Jul 18 '22 07:07 Yzhiqiang

This pull request introduces 1 alert when merging 9e6598852a090c54cc8433f134cf98ab52e083d7 into a986644af2da27815cdca25828a3a41e943d953a - view on LGTM.com

new alerts:

  • 1 for Boxed variable is never null

lgtm-com[bot] avatar Sep 15 '22 07:09 lgtm-com[bot]

This pull request introduces 1 alert when merging 3528b74e021e4e12eaf41982a05e46128b1835e7 into a986644af2da27815cdca25828a3a41e943d953a - view on LGTM.com

new alerts:

  • 1 for Boxed variable is never null

lgtm-com[bot] avatar Sep 15 '22 17:09 lgtm-com[bot]

Codecov Report

Merging #4787 (3e0534f) into develop (caeb231) will decrease coverage by 0.10%. The diff coverage is 9.61%.

:exclamation: Current head 3e0534f differs from pull request most recent head e71aca7. Consider uploading reports for the commit e71aca7 to get more accurate results

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4787      +/-   ##
=============================================
- Coverage      48.62%   48.51%   -0.11%     
+ Complexity      4052     4050       -2     
=============================================
  Files            732      736       +4     
  Lines          25773    25825      +52     
  Branches        3173     3175       +2     
=============================================
- Hits           12532    12529       -3     
- Misses         11909    11957      +48     
- Partials        1332     1339       +7     
Impacted Files Coverage Δ
...er/console/controller/BranchSessionController.java 100.00% <ø> (ø)
...seata/server/console/param/ConfigurationParam.java 0.00% <0.00%> (ø)
...ava/io/seata/server/console/vo/GlobalConfigVO.java 0.00% <0.00%> (ø)
...ver/console/impl/db/GlobalConfigDBServiceImpl.java 18.18% <18.18%> (ø)
...ver/console/controller/GlobalConfigController.java 23.07% <23.07%> (ø)
...source/AbstractDataSourceCacheResourceManager.java 42.85% <0.00%> (-42.86%) :arrow_down:
...n/src/main/java/io/seata/common/util/IdWorker.java 77.08% <0.00%> (-6.25%) :arrow_down:
.../main/java/io/seata/rm/BaseDataSourceResource.java 31.81% <0.00%> (-3.04%) :arrow_down:
...r/console/impl/file/GlobalLockFileServiceImpl.java 94.87% <0.00%> (-2.57%) :arrow_down:
...rage/redis/store/RedisTransactionStoreManager.java 66.09% <0.00%> (-0.86%) :arrow_down:
... and 3 more

codecov-commenter avatar Sep 19 '22 02:09 codecov-commenter

This pull request introduces 1 alert when merging 144b8b1ca92259d66dc48de68afcb204d0cdf9f8 into a986644af2da27815cdca25828a3a41e943d953a - view on LGTM.com

new alerts:

  • 1 for Boxed variable is never null

lgtm-com[bot] avatar Sep 19 '22 02:09 lgtm-com[bot]

This pull request introduces 1 alert when merging 144b8b1ca92259d66dc48de68afcb204d0cdf9f8 into f7f7e239986b69709cc3a2ede56b3318debbb597 - view on LGTM.com

new alerts:

  • 1 for Boxed variable is never null

lgtm-com[bot] avatar Sep 19 '22 05:09 lgtm-com[bot]