incubator-seata icon indicating copy to clipboard operation
incubator-seata copied to clipboard

feature : skip list for undo data validation

Open Bughue opened this issue 2 years ago • 1 comments

  • [ ] I have registered the PR changes.

Ⅰ. Describe what this PR did

新增配置client.undo.dataValidation.skip ,表示可跳过校验的列表(以,分隔) 此配置在client.undo.dataValidation = true时生效。 满足跳过的逻辑是:beforeImage, afterImage , currentImage 其中某个的tableName存在于这个skip列表中。 新增了test,以及修复了之前test不严谨的部分(由于tableMeta被mock了所以setTableMeta会覆盖掉tableName)

Ⅱ. Does this pull request fix one issue?

fixes https://github.com/seata/seata/issues/4566

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Bughue avatar May 06 '22 11:05 Bughue

Codecov Report

Merging #4585 (9f44c76) into 2.x (e69627d) will decrease coverage by 0.14%. The diff coverage is 76.47%.

:exclamation: Current head 9f44c76 differs from pull request most recent head fa005ad. Consider uploading reports for the commit fa005ad to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #4585      +/-   ##
============================================
- Coverage     48.73%   48.60%   -0.14%     
+ Complexity     4339     4319      -20     
============================================
  Files           778      775       -3     
  Lines         27454    27401      -53     
  Branches       3412     3408       -4     
============================================
- Hits          13380    13317      -63     
- Misses        12677    12685       +8     
- Partials       1397     1399       +2     
Impacted Files Coverage Δ
...c/main/java/io/seata/common/ConfigurationKeys.java 0.00% <ø> (ø)
...seata/rm/datasource/undo/AbstractUndoExecutor.java 68.70% <75.00%> (-0.31%) :arrow_down:
.../java/io/seata/rm/datasource/DataCompareUtils.java 66.99% <77.77%> (+2.04%) :arrow_up:

... and 23 files with indirect coverage changes

codecov-commenter avatar May 07 '22 02:05 codecov-commenter

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 12 '22 13:12 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: Bughue
:x: wangliang181230
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Dec 12 '22 13:12 CLAassistant