incubator-seata
incubator-seata copied to clipboard
feature: support servicecomb-service-center and servicecomb-kie
- [ ] I have registered the PR changes.
Ⅰ. Describe what this PR did
Support seata connect to servicecomb-service-center Support seata connect to servicecomb-kie
Ⅱ. Does this pull request fix one issue?
#4192
Ⅲ. Why don't you add test cases (unit test/integration test)?
It need running servicecomb-service-center and servicecomb-kie first,so it is hard to write unit test. We will add a sample to seata-samples based on the demo below later.
Ⅳ. Describe how to verify it
There is a demo show how to use it.
Ⅴ. Special notes for reviews
Hi @slievrly @a364176773 ,
Could you help to trigger the build?
And I find the PR is frequently conflict with other commits, what can I do to make this PR to be merged ?
Thanks very much!
Hi @slievrly @a364176773 , Is there any plan for this PR?
Hi @slievrly @a364176773 , what is progress about this? can you help us to trigger this version
I'm sorry, I'm just seeing this pr now and I'll keep pushing this pr
I'm sorry, I'm just seeing this pr now and I'll keep pushing this pr
thanks very much ,i will fix the Checkstyle errors.
Codecov Report
Merging #4513 (0369282) into develop (06c2a50) will decrease coverage by
0.09%
. The diff coverage is9.70%
.
:exclamation: Current head 0369282 differs from pull request most recent head 8d84312. Consider uploading reports for the commit 8d84312 to get more accurate results
@@ Coverage Diff @@
## develop #4513 +/- ##
=============================================
- Coverage 49.23% 49.13% -0.10%
- Complexity 4117 4118 +1
=============================================
Files 737 739 +2
Lines 25827 25884 +57
Branches 3193 3181 -12
=============================================
+ Hits 12715 12719 +4
- Misses 11764 11811 +47
- Partials 1348 1354 +6
Impacted Files | Coverage Δ | |
---|---|---|
...java/io/seata/discovery/registry/RegistryType.java | 0.00% <0.00%> (ø) |
|
...ta/spring/boot/autoconfigure/StarterConstants.java | 100.00% <ø> (ø) |
|
...properties/config/ConfigServicecombProperties.java | 4.00% <4.00%> (ø) |
|
...erties/registry/RegistryServicecombProperties.java | 4.95% <4.95%> (ø) |
|
...core/src/main/java/io/seata/config/ConfigType.java | 78.57% <100.00%> (+1.64%) |
:arrow_up: |
...toconfigure/SeataCoreEnvironmentPostProcessor.java | 97.05% <100.00%> (+0.63%) |
:arrow_up: |
...m/datasource/exec/oracle/OracleInsertExecutor.java | 62.50% <0.00%> (-11.19%) |
:arrow_down: |
...urce/exec/postgresql/PostgresqlInsertExecutor.java | 43.75% <0.00%> (-7.68%) |
:arrow_down: |
...ing/annotation/GlobalTransactionalInterceptor.java | 31.92% <0.00%> (-1.22%) |
:arrow_down: |
...src/main/java/io/seata/rm/tcc/TCCFenceHandler.java | 0.00% <0.00%> (ø) |
|
... and 5 more |
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.
:white_check_mark: slievrly
:white_check_mark: funky-eyes
:x: zhaozw
You have signed the CLA already but the status is still pending? Let us recheck it.
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 3 committers have signed the CLA.
:x: slievrly
:x: zhaozw
:x: a364176773
You have signed the CLA already but the status is still pending? Let us recheck it.
Due to code conflicts and age, if you are still interested in participating in the community, please resubmit this pr to the 2.x branch after resolving the conflict. 由于代码冲突以及年代久远,如果你还有兴趣参与到社区,请解决完冲突后重新请提交这份pr至2.x分支中