incubator-seata icon indicating copy to clipboard operation
incubator-seata copied to clipboard

feature: seata support jdk17

Open funky-eyes opened this issue 2 years ago • 2 comments

  • [ ] I have registered the PR changes.

Ⅰ. Describe what this PR did

byte-buddy替换cglib

Ⅱ. Does this pull request fix one issue?

fixes #4123 fixes #4663 fixes #4703 fixes #4752 fixes #4821

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

funky-eyes avatar Mar 04 '22 13:03 funky-eyes

Codecov Report

Merging #4434 (c5ae741) into develop (bf99018) will decrease coverage by 0.42%. The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4434      +/-   ##
=============================================
- Coverage      48.95%   48.53%   -0.43%     
+ Complexity      4168     4134      -34     
=============================================
  Files            741      741              
  Lines          26521    26521              
  Branches        3294     3294              
=============================================
- Hits           12984    12871     -113     
- Misses         12129    12255     +126     
+ Partials        1408     1395      -13     
Impacted Files Coverage Δ
.../main/java/io/seata/config/ConfigurationCache.java 74.07% <100.00%> (ø)
...ava/io/seata/server/metrics/MetricsSubscriber.java 14.78% <0.00%> (-64.35%) :arrow_down:
...er/src/main/java/io/seata/server/ServerRunner.java 50.00% <0.00%> (-15.39%) :arrow_down:
...erver/storage/file/session/FileSessionManager.java 48.40% <0.00%> (-5.74%) :arrow_down:
...ver/storage/redis/session/RedisSessionManager.java 45.61% <0.00%> (-5.27%) :arrow_down:
...o/seata/server/coordinator/DefaultCoordinator.java 44.26% <0.00%> (-4.51%) :arrow_down:
.../java/io/seata/server/coordinator/DefaultCore.java 44.97% <0.00%> (-2.96%) :arrow_down:
...rage/redis/store/RedisTransactionStoreManager.java 72.06% <0.00%> (-2.62%) :arrow_down:
...o/seata/server/session/AbstractSessionManager.java 58.20% <0.00%> (-1.50%) :arrow_down:
...in/java/io/seata/server/session/BranchSession.java 79.13% <0.00%> (-1.44%) :arrow_down:
... and 8 more

codecov-commenter avatar Mar 04 '22 14:03 codecov-commenter

springboot 2.5最新版本到 2.5.14了,直接升到最高小版本吧。

wangliang181230 avatar Aug 17 '22 03:08 wangliang181230

image so,seata still not support jdk17?

luojunjiess avatar Oct 14 '22 09:10 luojunjiess

@luojunjiess

这个pr就是支持jdk17的

funky-eyes avatar Oct 24 '22 03:10 funky-eyes

@luojunjiess

这个pr就是支持jdk17的

请问什么时候能合并此 PR 发布新版本以支持 JDK17 呢? 谢谢!

DreamSaddle avatar Nov 26 '22 05:11 DreamSaddle

这个PR应该是server端的启动脚本,兼容JDK17。 client之前就已经兼容了的。当然有部分第三方组件不兼容JDK17,选用不兼容的组件时,在JDK17下也是无法使用的。

wangliang181230 avatar Nov 28 '22 04:11 wangliang181230

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 12 '22 13:12 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

:white_check_mark: xingfudeshi
:x: wangliang181230
:x: a364176773
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Dec 12 '22 13:12 CLAassistant