incubator-seata icon indicating copy to clipboard operation
incubator-seata copied to clipboard

feature: Integrate RocketMQ into Seata

Open GasolLY opened this issue 4 years ago • 9 comments

Ⅰ. Describe what this PR did

透过Spring的后置代理器实现了RocketMQ Bean的拦截,并返回了静态代理类.

Ⅱ. Does this pull request fix one issue?

fixes #3752.

Ⅲ. Test case

https://github.com/GasolLY/seata-rocketmq-test

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

GasolLY avatar Aug 23 '21 05:08 GasolLY

Codecov Report

Merging #3974 (6a85838) into 2.x (25999c3) will decrease coverage by 0.23%. The diff coverage is 6.25%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #3974      +/-   ##
============================================
- Coverage     48.42%   48.20%   -0.23%     
+ Complexity     4171     4168       -3     
============================================
  Files           764      769       +5     
  Lines         26892    26979      +87     
  Branches       3348     3348              
============================================
- Hits          13023    13004      -19     
- Misses        12467    12591     +124     
+ Partials       1402     1384      -18     
Impacted Files Coverage Δ
...ration/tx/api/fence/DefaultCommonFenceHandler.java 0.00% <0.00%> (ø)
...gration/tx/api/fence/config/CommonFenceConfig.java 0.00% <0.00%> (ø)
...pi/fence/store/db/CommonFenceStoreDataBaseDAO.java 0.00% <0.00%> (ø)
...x/api/fence/store/db/sql/CommonFenceStoreSqls.java 0.00% <0.00%> (ø)
...erceptor/parser/DefaultResourceRegisterParser.java 0.00% <0.00%> (ø)
...ata/integration/tx/api/json/DefaultJsonParser.java 0.00% <0.00%> (ø)
.../autoconfigure/SeataRocketMQAutoConfiguration.java 0.00% <0.00%> (ø)
...ain/java/io/seata/rm/fence/SpringFenceHandler.java 0.00% <0.00%> (ø)
...otation/scannercheckers/PackageScannerChecker.java 0.00% <0.00%> (ø)
.../java/io/seata/rm/tcc/rocketmq/RocketMQAspect.java 0.00% <0.00%> (ø)
... and 20 more

codecov-commenter avatar Sep 28 '21 01:09 codecov-commenter

Aop is based on dynamic proxy, the middleware layer should use the underlying technology

wxbty avatar Oct 20 '21 02:10 wxbty

Aop is based on dynamic proxy, the middleware layer should use the underlying technology Get it😁

GasolLY avatar Oct 20 '21 11:10 GasolLY

再补充一下测试用例

funky-eyes avatar Oct 21 '21 09:10 funky-eyes

再补充一下测试用例

Fixed: https://github.com/GasolLY/seata-rocketmq-test

GasolLY avatar May 27 '22 10:05 GasolLY

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 12 '22 13:12 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 4 committers have signed the CLA.

:white_check_mark: wangliang181230
:x: GasolLY
:x: a364176773
:x: slievrly
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Dec 12 '22 13:12 CLAassistant

Please resolve code conflicts

funky-eyes avatar Nov 27 '23 02:11 funky-eyes

https://github.com/apache/incubator-seata/pull/6230

Bughue avatar Jan 18 '24 11:01 Bughue