incubator-seata-go icon indicating copy to clipboard operation
incubator-seata-go copied to clipboard

fix Background Goroutines Cannot Exit Gracefully

Open WyRainBow opened this issue 1 month ago • 3 comments

fix #992

WyRainBow avatar Nov 23 '25 08:11 WyRainBow

Codecov Report

:x: Patch coverage is 57.50000% with 17 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 56.82%. Comparing base (b18bcb0) to head (e5b4134).

Files with missing lines Patch % Lines
pkg/datasource/sql/datasource/base/meta_cache.go 48.38% 15 Missing and 1 partial :warning:
pkg/datasource/sql/at_resource_manager.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #996      +/-   ##
==========================================
+ Coverage   56.49%   56.82%   +0.33%     
==========================================
  Files         266      266              
  Lines       17484    17494      +10     
==========================================
+ Hits         9877     9941      +64     
+ Misses       6772     6720      -52     
+ Partials      835      833       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Nov 23 '25 08:11 codecov-commenter

Perhaps you could clone the samples repository and replace its "seata go" dependency with your modified local version to verify if it works correctly.

Verified by cloning apache/seata-go-samples, replacing the dependency with my local incubator-seata-go via go mod edit -replace ..., running go mod tidy, and all go test ./... runs succeeded on both the samples repo and the main repo.

WyRainBow avatar Dec 06 '25 06:12 WyRainBow

Plz check and resolve the conflicts.

tew-axiom avatar Dec 20 '25 09:12 tew-axiom

Hi, please fix the CI when you have time.

LucienShen-Liu avatar Dec 21 '25 04:12 LucienShen-Liu