incubator-seata-go icon indicating copy to clipboard operation
incubator-seata-go copied to clipboard

fix bugs detected by doubao

Open Wangzy455 opened this issue 3 months ago • 6 comments

What this PR does: for https://github.com/apache/incubator-seata-go/issues/879

Which issue(s) this PR fixes: fix some issue about getty

Wangzy455 avatar Sep 26 '25 13:09 Wangzy455

Codecov Report

:x: Patch coverage is 0% with 27 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 56.41%. Comparing base (b18bcb0) to head (0b8fa14).

Files with missing lines Patch % Lines
pkg/remoting/getty/listener.go 0.00% 21 Missing :warning:
pkg/remoting/getty/session_manager.go 0.00% 5 Missing :warning:
pkg/remoting/getty/getty_remoting.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #898      +/-   ##
==========================================
- Coverage   56.49%   56.41%   -0.08%     
==========================================
  Files         266      266              
  Lines       17484    17511      +27     
==========================================
+ Hits         9877     9879       +2     
- Misses       6772     6798      +26     
+ Partials      835      834       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Sep 27 '25 05:09 codecov-commenter

would you like to add some uts for this PR?

AlexStocks avatar Sep 28 '25 01:09 AlexStocks

would you like to add some uts for this PR?

OK, I will improve the unit test to verify the newly added reconnection method

Wangzy455 avatar Sep 28 '25 07:09 Wangzy455

would you like to add some uts for this PR?

OK, I will improve the unit test to verify the newly added reconnection method

I removed the reconnect method and only kept the resource cleanup part.

Wangzy455 avatar Oct 10 '25 12:10 Wangzy455

Please handle the above comments.

LucienShen-Liu avatar Nov 22 '25 10:11 LucienShen-Liu