incubator-seata-go icon indicating copy to clipboard operation
incubator-seata-go copied to clipboard

dubbo-go 将 seata-golang替换为seata-go

Open luky116 opened this issue 2 years ago • 4 comments

What would you like to be added: https://github.com/apache/dubbo-go-samples/tree/1.5/shopping-order

Why is this needed:

luky116 avatar Sep 03 '22 13:09 luky116

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Title: dubbo-go replaces seata-golang with seata-go

Issues-translate-bot avatar Sep 03 '22 13:09 Issues-translate-bot

dubbo-go-samples 这里有两个: https://github.com/apache/dubbo-go-samples/tree/1.5/seata

https://github.com/apache/dubbo-go-samples/tree/1.5/shopping-order

mosn一个: https://github.com/mosn/mosn/pulls?q=is%3Apr+seata

AlexStocks avatar Sep 03 '22 13:09 AlexStocks

Assign to me

betterwinsone avatar Sep 04 '22 06:09 betterwinsone

betterwinsone

ok

luky116 avatar Sep 04 '22 12:09 luky116

image 给dubbo-go-samples 增加seata-go例子的时候报错了。 排查发现是seata-go使用的github.com/dubbogo/gost 是v1.12.5版本,而dubbo-go-samples 使用的是v1.11.21-0.20220503144918-9e5ae44480af 版本比较老,seata-go引入到dubbo-go-samples后,会自动升级github.com/dubbogo/gost 到v1.12.5版本,就导致了截图中的错误,是否可以将seata-go的例子提交到dubbo-go-samples master分支?我看dubbo-go-samples master分支使用的github.com/dubbogo/gost 的版本也是v1.12.5,应该就不会报错了 @luky116 @AlexStocks

betterwinsone avatar Sep 28 '22 15:09 betterwinsone

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


image An error was reported when adding a seata-go example to dubbo-go-samples. The investigation found that github.com/dubbogo/gost used by seata-go is version v1.12.5, while dubbo-go-samples uses v1.11.21-0.20220503144918-9e5ae44480af version is relatively old, and seata-go is introduced into dubbo-go- After the samples, github.com/dubbogo/gost will be automatically upgraded to v1.12.5, which leads to the error in the screenshot. Is it possible to submit the seata-go example to the dubbo-go-samples master branch? I see dubbo-go The version of github.com/dubbogo/gost used by the -samples master branch is also v1.12.5, so there should be no error @luky116 @AlexStocks

Issues-translate-bot avatar Sep 28 '22 15:09 Issues-translate-bot

尝试把版本升级到 3.0.2 试试

AlexStocks avatar Sep 29 '22 04:09 AlexStocks

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Try to upgrade the version to 3.0.2 try

Issues-translate-bot avatar Sep 29 '22 04:09 Issues-translate-bot

已提交,检查通过,等待合并 https://github.com/apache/dubbo-go-samples/pull/418

betterwinsone avatar Oct 15 '22 11:10 betterwinsone

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Submitted, checked, waiting to be merged https://github.com/apache/dubbo-go-samples/pull/418

Issues-translate-bot avatar Oct 15 '22 11:10 Issues-translate-bot

Completed

betterwinsone avatar Nov 05 '22 07:11 betterwinsone