incubator-seata-go icon indicating copy to clipboard operation
incubator-seata-go copied to clipboard

Published 20 hours ago • verified publisher icon apache

enhancement: make time parameters easier to read

Open a631807682 opened this issue 1 year ago • 5 comments

What happened: I'm reading the seata-go code, but some parameters are hard for me to understand. The Timeout below is of type int32, but I can't figure out its unit, can we use type time.Duration instead? Or rename to TimeoutMillisecond?

https://github.com/seata/seata-go/blob/master/pkg/tm/transaction_executor.go#L68 https://github.com/seata/seata-go/blob/master/pkg/tm/global_transaction.go#L70

a631807682 avatar Aug 11 '22 07:08 a631807682

good issuse

jasondeng1997 avatar Aug 11 '22 14:08 jasondeng1997

Can you help me with a PR revision, thank you very much

106umao avatar Aug 11 '22 14:08 106umao

I fix it in this pr https://github.com/seata/seata-go/pull/204/files

jasondeng1997 avatar Aug 11 '22 15:08 jasondeng1997

assign me

jasondeng1997 avatar Aug 12 '22 02:08 jasondeng1997

I'm not sure if you're talking to me, I don't have permission to assign anyone, you can use the close keyword in the PR to associate this issue, so that everyone knows that the PR already exists.

a631807682 avatar Aug 12 '22 10:08 a631807682

close this issuse

jasondeng1997 avatar Aug 17 '22 00:08 jasondeng1997