incubator-ponymail icon indicating copy to clipboard operation
incubator-ponymail copied to clipboard

Bug: parser fails to detect inline attachments

Open sebbASF opened this issue 6 years ago • 1 comments

The parser completely ignores inline attachments. For example, the message [1] includes a reference to an attachment, but it is not shown in the list view, only in the source view.

Compare withe the mod_mbox version [2], which shows the attachment

It might make sense to display the message structure in the same way as mod_mbox. This would also allow easy access to HTML alternatives, which are also currently hidden.

[1] https://lists.apache.org/thread.html/918b4a61add01902e2dfbf1a17ba945b7d721e9cdf9d0235d374eb1d@1250786123@%3Cuser.zookeeper.apache.org%3E [2] http://mail-archives.apache.org/mod_mbox/zookeeper-user/200908.mbox/%[email protected]%3e

sebbASF avatar Aug 11 '19 14:08 sebbASF

The archiver code currently walks the message parts twice: in msgbody and msgfiles.

This makes it harder to ensure all parts are accounted for exactly once.

At present the methods each look for specific headers, which is how some parts have been missed.

There will need to be some co-ordination between the two methods to avoid omissions and duplications (there's no point creating an attachment record for the main body).

Alternatively, the parts could be walked once and allocated as body or attachment.

sebbASF avatar Aug 11 '19 14:08 sebbASF