incubator-ponymail icon indicating copy to clipboard operation
incubator-ponymail copied to clipboard

setup.py tries to install Python modules

Open sebbASF opened this issue 7 years ago • 1 comments

If the import of elasticsearch fails, setup.py tries to install some Python modules. This uses pip3 and is unconditionally tried if the current user is root.

I think this is out of scope for the setup script. It's also potentially dangerous to run external processes as root. Also the installation may not be using pip3.

Setup.py should report an issue if a required module is missing, but should not unconditionally install them.

sebbASF avatar May 27 '18 11:05 sebbASF

It looks as though this processing was originally done in the install.py script.

sebbASF avatar May 27 '18 11:05 sebbASF