avoid to modify idl generate code in client
Bug Report
Please answer these questions before submitting your issue. Thanks!
I found java client use 10 idl files, c++ use 12 idl files, go use 11 idl files.
➜ grep 'namespace java' idl/* | wc -l
10
➜ grep 'namespace go' idl/* | wc -l
11
➜ grep 'namespace cpp' idl/* | wc -l
12
Though java use 10 idl files, but java client only generate 9 idl files code. This is strange, and hard to maintain.
For java client,
I think either
just remove namespace java from dns.thrift , not use the dns.thrift to generate java code.
or
use the generate code of dns.thrift, modify the java-thrift lib.
-
What did you do? If possible, provide a recipe for reproducing the error.
-
What did you expect to see?
-
What did you see instead?
-
What version of Pegasus are you using?
Maybe it's a mistake, I'll check it later!
@shalk
- java client use 10 idl files, c++ use 12 idl files, go use 11 idl files
It's because each language client has different function set. For example, the admin-cli is using go-client to support some CLI commands, but the Java client doesn't have such function. So you can see the go-client use an extra idl/replica_admin.thrift.
- Though java use 10 idl files, but java client only generate 9 idl files code
Yes, the dsn.thrift is used for place holder, I'll try to clarify it.