incubator-pegasus icon indicating copy to clipboard operation
incubator-pegasus copied to clipboard

feat(FQDN): Replace rpc_address to host_prot for function & Add host_port on thrift struct

Open GehaFearless opened this issue 2 years ago • 2 comments

issue: https://github.com/apache/incubator-pegasus/issues/1659

1.Replace type rpc_address to host_port on class variables. Modify the parameter types of the function if necessary.

2.Add type 'host_port' member to thrift struct which have 'rpc_address'.

GehaFearless avatar Oct 26 '23 03:10 GehaFearless

Some changes can be separated to another patch, for example, the changes in:

  1. src/common/json_helper.h and its tests.
  2. src/runtime/rpc/rpc_host_port.h (add some tests as well)

acelyc111 avatar Dec 12 '23 09:12 acelyc111

TODO (in next patches):

  • [x] Just pass host_post parameter, don't pass rpc_address parameters for generate_balancer_request and new_proposal_action
  • [x] Change the -r parameter to resolve hostname to IP in Cpp-shell.
  • [x] Use hostname for backup in get_remote_chkpt_dirname()

acelyc111 avatar Jan 22 '24 06:01 acelyc111