incubator-pegasus icon indicating copy to clipboard operation
incubator-pegasus copied to clipboard

Feature(new_metrics): migrate table-level metrics

Open empiredan opened this issue 2 years ago • 2 comments

There are following metrics all of which are in class replica, replica.cpp file:

_counters_table_level_latency[]

Therefore, table-level entity can just be defined in replica.cpp, where they are also instantiated in class replica, to which the above metrics are attached.

The table-level metrics originate from https://github.com/XiaoMi/rdsn/pull/336 which is tracked by issue https://github.com/apache/incubator-pegasus/issues/406.

empiredan avatar Jan 28 '23 08:01 empiredan

Now that we can aggregate on collector, is it necessary to keep and aggregate these metrics on each replica server?

acelyc111 avatar Jan 31 '23 08:01 acelyc111

Now that we can aggregate on collector, is it necessary to keep and aggregate these metrics on each replica server?

OK, it's better to aggregate table metrics based on replica metrics, we can suspend this task.

empiredan avatar Feb 02 '23 07:02 empiredan