incubator-pegasus icon indicating copy to clipboard operation
incubator-pegasus copied to clipboard

feat(thirdparty): use official rocksdb

Open acelyc111 opened this issue 2 years ago • 1 comments

https://github.com/apache/incubator-pegasus/issues/1047

For some historical reasons, we use the Xiaomi modified rocksdb library, since Pegasus 2.1.0, we have removed all modifications on rocksdb, only left some code to keep compatiable [1], now before 2.4.0 releasing, it's a chance to switch to the official version.

It's expect that rdsn/thirdparty/rocksdb_fix_atomic_flush_0879c240.patch must be corresponding to this patch [2].

ATTENTION: There is a limit that the server must be upgraded from 2.1, 2.2 or 2.3, to ensure that there is no Pegasus introduced tags which the official rocksdb doesn't recognize left in MANIFEST file.

  1. https://github.com/XiaoMi/pegasus-rocksdb/commits/v6.6.4-compatible
  2. https://github.com/XiaoMi/pegasus-rocksdb/commit/ef29819c7a1ea9334ae170f506b653757f517a52

acelyc111 avatar Jul 12 '22 14:07 acelyc111

hope block merge before release 2.4

Better to convert it to draft :)

levy5307 avatar Jul 14 '22 10:07 levy5307

hope block merge before release 2.4

@foreverneverer Since we have created an separete branch v2.4 for releasing 2.4.0, so could we continue this work?

acelyc111 avatar Sep 27 '22 16:09 acelyc111