support unix sockets with memcached and redis

[GoogleCodeExporter]

mod_pagespeed has a copy of apr_memcache.c, with some local modifications.  
Support for unix sockets was added upstream a few months ago, and there was a 
request to ngx-pagespeed-discuss by someone who wanted to use them.

The patch for unix sockets is [1] but we might want to just patch our local 
modifications onto the most up-to-date apr_memcache.c to get other bugfixes 
from the last year or so.

[1] 
http://mail-archives.apache.org/mod_mbox/apr-commits/201305.mbox/%3C201305191131
[email protected]%3E

Original issue reported on code.google.com by [email protected] on 2 Aug 2013 at 2:35

[Miragetek]

Hi, was this ever added? I can see it mentioned as a patch. where can I get the patch to merge into my local build?

thanks in advance

[oschaaf]

I remember the feature request but not the patch, can you point it out?

[Miragetek]

Hi thanks for getting back to me. Its a bit convoluted but here we go... from https://github.com/apache/incubator-pagespeed-mod/issues/760 it mentions a broken ink to the patches mailbox. http://mail-archives.apache.org/mod_mbox/apr-commits/201305.mbox/%[email protected]%3E

a bit of playing with the URL gets you the mailbox file that you can open with a text editor to get to the patch.

http://mail-archives.apache.org/mod_mbox/apr-commits/201305.mbox

I haven't tried any of the patches in the mailing list as I've only got a production system. Which is why I was asking if it was ever committed.

It would be great if it could be added.

---

From: Otto van der Schaaf [email protected] Sent: 12 August 2020 17:51 To: apache/incubator-pagespeed-mod [email protected] Cc: Ben White [email protected]; Comment [email protected] Subject: Re: [apache/incubator-pagespeed-mod] support unix sockets with memcached and redis (#760)

I remember the feature request but not the patch, can you point it out?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/apache/incubator-pagespeed-mod/issues/760#issuecomment-672990722, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKUTHAXEUYT6DTGSTPAMJBTSALCA5ANCNFSM4P47FHUA.

[oschaaf]

@Miragetek thanks for pointing that out. To be honest, unfortunately it looks like that won't be a trivial exercise (at least for me) to incorporate into this project, probably due to me lacking specific knowledge about apr/aprutil. But maybe someday, someone will pick it up, and then I think the relatively easy way you made this discoverable might be helpful.

[Miragetek]

Thanks Otto, I appreciate you getting back to me about this.

Yeah, I guess its not a widely requested feature. So we will see what the future holds.

It's not every day you get a reply from a celebrity.

So please forgive the fanboy bit below lol. [Animated GIF]

---

From: Otto van der Schaaf [email protected] Sent: 12 August 2020 22:15 To: apache/incubator-pagespeed-mod [email protected] Cc: Ben White [email protected]; Mention [email protected] Subject: Re: [apache/incubator-pagespeed-mod] support unix sockets with memcached and redis (#760)

@Miragetekhttps://github.com/Miragetek thanks for pointing that out. To be honest, unfortunately it looks like that won't be a trivial exercise (at least for me) to incorporate into this project, probably due to me lacking specific knowledge about apr/aprutil. But maybe someday, someone will pick it up, and then I think the relatively easy way you made this discoverable might be helpful.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/apache/incubator-pagespeed-mod/issues/760#issuecomment-673114756, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKUTHATV7FZF6RVVAMU2DY3SAMA5VANCNFSM4P47FHUA.