incubator-pagespeed-mod icon indicating copy to clipboard operation
incubator-pagespeed-mod copied to clipboard

Published 20 hours ago • verified publisher icon apache

Prefer Paint Timing API over chrome.loadTimes()

Open injust opened this issue 6 years ago • 3 comments

Fixes apache/incubator-pagespeed-ngx#1537

injust avatar Oct 14 '18 10:10 injust

This looks good to me; did you get a chance to test this? Is this ready for merging?

oschaaf avatar Oct 16 '18 08:10 oschaaf

Just tested with the mod_pagespeed build process. Indeed, Closure Compiler doesn't like the omission of var declarations.

Right now, getEntriesByType('paint') always returns an empty array. The entries only populate after the load event for window. Is it possible to defer running the entire instrumentation block?

I noticed that the build process uses pre-optimized files in net/instaweb/genfiles/rewriter, which will need to be updated. How were those initially generated?

injust avatar Dec 10 '18 17:12 injust

@injust is this good to go as far as you are concerned?

oschaaf avatar Jul 28 '20 18:07 oschaaf