incubator-livy
incubator-livy copied to clipboard
apache
[LIVY-758] Document how to attach to an existing session from Java client
What changes were proposed in this pull request?
Add an explicit way to set the session when connecting from the Java client. https://issues.apache.org/jira/browse/LIVY-758
How was this patch tested?
Unit tested through HttpClientSpec.
I could not assign myself the relate jira, how can I do it? @mgaido91 @vanzin @jerryshao
@tmnd1991 you can't, JIRAs are assigned when related patches are merged and they are resolved
@tmnd1991 you can't, JIRAs are assigned when related patches are merged and they are resolved
Then I think contributing section is wrong :)
I changed what you suggested @mgaido91 , thanks for the review. Tagging @ajbozarth as he asked on Jira :)
@mgaido91 I think your mixing up how Spark handles JIRA assignments with Livy's policy. We assign JIRAs once a PR is open for the issue. For some reason though, I can't assign issues to @tmnd1991 in the Livy JIRA at the moment. We had this issue before but I can't remember how we solved it.
@tmnd1991 A heads up, when you force push updates to commits it makes it difficult to track your changes as you address review (eg. I can't tell which of @mgaido91 comments you've addressed because there's no history to compare to). Since we squash all commits in a PR before merging the quantity of commits in a PR isn't an issue.
As for your code, I read through it and I don't see any issues with the current code, but I don't have to time check it out and more thoroughly test it so I will defer to @mgaido91 on final approval for this PR.
@tmnd1991 A heads up, when you force push updates to commits it makes it difficult to track your changes as you address review (eg. I can't tell which of @mgaido91 comments you've addressed because there's no history to compare to). Since we squash all commits in a PR before merging the quantity of commits in a PR isn't an issue.
Good, I did not know if the squash before merge was a "thing" in Livy repo, I won't do the same mistake again :)
As for your code, I read through it and I don't see any issues with the current code, but I don't have to time check it out and more thoroughly test it so I will defer to @mgaido91 on final approval for this PR.
👍
@mgaido91 I think your mixing up how Spark handles JIRA assignments with Livy's policy. We assign JIRAs once a PR is open for the issue. For some reason though, I can't assign issues to @tmnd1991 in the Livy JIRA at the moment. We had this issue before but I can't remember how we solved it.
Sorry, I saw the same pattern being followed in Livy too in practice so I assumed it was the same. I think the point is that @tmnd1991 has to be added to the contributors in JIRA. I'll do that when resolving the JIRA.