incubator-kie-optaplanner icon indicating copy to clipboard operation
incubator-kie-optaplanner copied to clipboard

Upgrade Optaplanner to Quarkus 3.8.0

Open lucamolteni opened this issue 1 year ago • 6 comments

Upgraded to Quarkus 3.8.0 LTS

  • Removed org.drools.util.RemoveCommentsMain as with the new quarkus version is not useful anymore
  • Backport of Timefold migration to new DevUI 2.0 see original commit: https://github.com/TimefoldAI/timefold-solver/commit/8d5864df897c56b0ccfaaffbbf14908f04db61f4#diff-8b943be542be64385a97ac89619e4bcb7be615cf84f1623acd89357e131226af
  • Fix Optaplanner Operator, disabled SSA as with the current version of the code it's broken

JIRA

https://github.com/apache/incubator-kie-issues/issues/1021 https://github.com/apache/incubator-kie-issues/issues/958

Checklist

  • [ ] Documentation updated if applicable.
  • [ ] Release notes updated if applicable.
  • [ ] Upgrade recipe provided if applicable.
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request checks
    Please add comment: Jenkins retest this

  • for a specific pull request check
    please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] tests

  • for a full downstream build

    • for jenkins job: please add comment: Jenkins run fdb
    • for github actions job: add the label run_fdb
  • for a compile downstream build
    please add comment: Jenkins run cdb

  • for a full production downstream build
    please add comment: Jenkins execute product fdb

  • for an upstream build
    please add comment: Jenkins run upstream

  • for quarkus branch checks
    Run checks against Quarkus current used branch
    Please add comment: Jenkins run quarkus-branch

  • for a quarkus branch specific check
    Run checks against Quarkus current used branch
    Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] quarkus-branch

  • for quarkus main checks
    Run checks against Quarkus main branch
    Please add comment: Jenkins run quarkus-main

  • for a specific quarkus main check
    Run checks against Quarkus main branch
    Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] quarkus-branch

  • for quarkus lts checks
    Run checks against Quarkus lts branch
    Please add comment: Jenkins run quarkus-lts

  • for a specific quarkus lts check
    Run checks against Quarkus lts branch
    Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] quarkus-lts

  • for native checks
    Run native checks
    Please add comment: Jenkins run native

  • for a specific native check
    Run native checks Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] native

  • for native lts checks
    Run native checks against quarkus lts branch Please add comment: Jenkins run native-lts

  • for a specific native lts check
    Run native checks against quarkus lts branch Please add comment: Jenkins (re)run [optaplanner|optaplanner-quickstarts] native-lts

CI Status

You can check OptaPlanner repositories CI status from Chain Status webpage.

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

lucamolteni avatar Mar 20 '24 13:03 lucamolteni

@yurloc see this ^

lucamolteni avatar Mar 20 '24 13:03 lucamolteni

PR job #1 was: UNSTABLE Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-optaplanner/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-optaplanner -u https://github.com/apache/incubator-kie-optaplanner/pull/3070 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/optaplanner/job/main/job/pullrequest_jobs/job/optaplanner-pr/job/PR-3070/1/display/redirect

Test results:

  • PASSED: 4984
  • FAILED: 1

Those are the test failures:

org.optaplanner.quarkus.it.devui.OptaPlannerDevUITest.testConstraintsPage
Expecting actual:
["org.optaplanner.quarkus.it.devui.domain/Maximize value length","org.optaplanner.quarkus.it.devui.domain/Don't assign 2 entities the same value."]
to contain exactly (and in same order):
["org.optaplanner.quarkus.it.devui.domain/Don't assign 2 entities the same value.",
"org.optaplanner.quarkus.it.devui.domain/Maximize value length"]
but there were differences at these indexes:
- element at index 0: expected ""org.optaplanner.quarkus.it.devui.domain/Don't assign 2 entities the same value."" but was ""org.optaplanner.quarkus.it.devui.domain/Maximize value length""
- element at index 1: expected ""org.optaplanner.quarkus.it.devui.domain/Maximize value length"" but was ""org.optaplanner.quarkus.it.devui.domain/Don't assign 2 entities the same value.""

kie-ci3 avatar Mar 20 '24 14:03 kie-ci3

btw quarkus already released 3.8.3 https://quarkus.io/blog/quarkus-3-8-3-released, so i guess there should not be a big diff, but good to have the latest LTS one ;) WDYT? @lucamolteni

mareknovotny avatar Mar 22 '24 14:03 mareknovotny

@yurloc https://github.com/apache/incubator-kie-optaplanner-quickstarts/pull/627

lucamolteni avatar Mar 26 '24 13:03 lucamolteni

@lucamolteni mind bump quarkus to 3.8.3? btw: thank you for this!

porcelli avatar Apr 04 '24 15:04 porcelli

@lucamolteni had to make the following change local to make it build:

diff --git i/optaplanner-persistence/optaplanner-persistence-xstream/pom.xml w/optaplanner-persistence/optaplanner-persistence-xstream/pom.xml
index 8f65d97677..113de384d1 100644
--- i/optaplanner-persistence/optaplanner-persistence-xstream/pom.xml
+++ w/optaplanner-persistence/optaplanner-persistence-xstream/pom.xml
@@ -77,6 +77,11 @@
       <artifactId>graal-sdk</artifactId>
       <scope>provided</scope>
     </dependency>
+    <dependency>
+      <groupId>org.graalvm.sdk</groupId>
+      <artifactId>nativeimage</artifactId>
+      <scope>provided</scope>
+    </dependency>
     <!-- Testing -->
     <dependency>
       <groupId>org.junit.jupiter</groupId>

porcelli avatar Apr 04 '24 15:04 porcelli

@lucamolteni @porcelli I guess we can close this PR, that's right?

yesamer avatar May 03 '24 09:05 yesamer