incubator-kie-kogito-runtimes icon indicating copy to clipboard operation
incubator-kie-kogito-runtimes copied to clipboard

Published 20 hours ago • verified publisher icon apache

Bump com.google.guava:guava from 29.0-jre to 32.0.0-jre in /.ci/jenkins/tests

Open dependabot[bot] opened this issue 1 year ago • 9 comments

Bumps com.google.guava:guava from 29.0-jre to 32.0.0-jre.

Release notes

Sourced from com.google.guava:guava's releases.

32.0.0

Maven

<dependency>
  <groupId>com.google.guava</groupId>
  <artifactId>guava</artifactId>
  <version>32.0.0-jre</version>
  <!-- or, for Android: -->
  <version>32.0.0-android</version>
</dependency>

Jar files

Guava requires one runtime dependency, which you can download here:

Javadoc

JDiff

Changelog

Security fixes

  • Reimplemented Files.createTempDir and FileBackedOutputStream to further address CVE-2020-8908 (#4011) and CVE-2023-2976 (#2575). (feb83a1c8f)

While CVE-2020-8908 was officially closed when we deprecated Files.createTempDir in Guava 30.0, we've heard from users that even recent versions of Guava have been listed as vulnerable in other databases of security vulnerabilities. In response, we've reimplemented the method (and the very rarely used FileBackedOutputStream class, which had a similar issue) to eliminate the insecure behavior entirely. This change could technically affect users in a number of different ways (discussed under "Incompatible changes" below), but in practice, the only problem users are likely to encounter is with Windows. If you are using those APIs under Windows, you should skip 32.0.0 and go straight to 32.0.1 which fixes the problem. (Unfortunately, we didn't think of the Windows problem until after the release. And while we warn that common.io in particular may not work under Windows, we didn't intend to regress support.) Sorry for the trouble.

Incompatible changes

Although this release bumps Guava's major version number, it makes no binary-incompatible changes to the guava artifact.

One change could cause issues for Widows users, and a few other changes could cause issues for users in more usual situations:

  • The new implementations of Files.createTempDir and FileBackedOutputStream throw an exception under Windows. This is fixed in 32.0.1. Sorry for the trouble.
  • guava-gwt now requires GWT 2.10.0.
  • This release makes a binary-incompatible change to a @Beta API in the separate artifact guava-testlib. Specifically, we changed the return type of TestingExecutors.sameThreadScheduledExecutor to ListeningScheduledExecutorService. The old return type was a package-private class, which caused the Kotlin compiler to produce warnings. (dafaa3e435)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the Security Alerts page.

dependabot[bot] avatar Oct 25 '23 08:10 dependabot[bot]

@elguardian @fjtirado shouldn't we use 32.0.1 As in https://github.com/apache/incubator-kie-kogito-runtimes/pull/3113 and skip this PR?

pefernan avatar Oct 25 '23 09:10 pefernan

@elguardian @pefernan Yes, see for example:

  • https://github.com/apache/incubator-kie-drools/pull/5332
  • https://github.com/apache/incubator-kie-drools/pull/5559

jomarko avatar Oct 25 '23 09:10 jomarko

@elguardian @fjtirado shouldn't we use 32.0.1 As in #3113 and skip this PR?

I think we should just remove the line from this POM

fjtirado avatar Oct 25 '23 10:10 fjtirado

@fjtirado may we ask you to backport #3113 into https://github.com/apache/incubator-kie-kogito-runtimes/tree/1.40.x branch ?

jomarko avatar Oct 25 '23 11:10 jomarko

PR job #1 was: UNSTABLE Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u https://github.com/apache/incubator-kie-kogito-runtimes/pull/3262 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3262/1/display/redirect

Test results:

  • PASSED: 3387
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.serverless.workflow.deployment.livereload.LiveReloadProcessorTest.testGrpc 1 expectation failed.
Expected status code but was .

kie-ci3 avatar Oct 25 '23 14:10 kie-ci3

@fjtirado may we ask you to backport #3113 into https://github.com/apache/incubator-kie-kogito-runtimes/tree/1.40.x branch ?

https://github.com/apache/incubator-kie-kogito-runtimes/pull/3265

fjtirado avatar Oct 25 '23 18:10 fjtirado

@dependabot rebase

yesamer avatar Jan 17 '24 14:01 yesamer

@dependabot rebase

yesamer avatar Jan 24 '24 20:01 yesamer

@dependabot rebase

yesamer avatar Feb 21 '24 08:02 yesamer

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot] avatar Mar 18 '24 09:03 dependabot[bot]

@dependabot rebase

yesamer avatar Mar 18 '24 09:03 yesamer

https://github.com/dependabot rebase

yesamer avatar Apr 16 '24 06:04 yesamer