incubator-kie-kogito-runtimes icon indicating copy to clipboard operation
incubator-kie-kogito-runtimes copied to clipboard

Published 20 hours ago • verified publisher icon apache

KOGITO-7626 Setup Maven wrapper and build-chain docs

Open radtriste opened this issue 1 year ago • 3 comments

  • https://github.com/kiegroup/kogito-pipelines/pull/565
  • https://github.com/kiegroup/kogito-runtimes/pull/2349

radtriste avatar Jul 22 '22 09:07 radtriste

HI @radtriste - thanks for that PR. I just have two question:

  1. I was expecting somewhere the removal of "3.8.6" hardcoded check inside kogito-dependencies-bom: am I missing it ? Is it still needed ?
  2. if it is needed to keep that enforce rule, would this mean that also on lacla machine we will have to use the mvnw (just asking) ? Thanks!

gitgabrio avatar Jul 25 '22 13:07 gitgabrio

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

sonarcloud[bot] avatar Jul 25 '22 13:07 sonarcloud[bot]

HI @radtriste - thanks for that PR. I just have two question:

  1. I was expecting somewhere the removal of "3.8.6" hardcoded check inside kogito-dependencies-bom: am I missing it ? Is it still needed ?

Well that does not solve the fact that we need to ensure Maven 3.8.6 is used ... The maven wrapper is just helping to use the correct maven version. But people still could use local installation of Maven and we need to make sure it is the right one...

  1. if it is needed to keep that enforce rule, would this mean that also on lacla machine we will have to use the mvnw (just asking) ?

What is lacla machine ? You can still use a local Maven installation but you will have to manage it yourself.

radtriste avatar Jul 25 '22 13:07 radtriste