incubator-kie-kogito-examples icon indicating copy to clipboard operation
incubator-kie-kogito-examples copied to clipboard

KOGITO-5502 CORS issue of data-index in kogito-examples

Open bxf12315 opened this issue 3 years ago • 7 comments

Many thanks for submitting your Pull Request :heart:!

Please make sure that your PR meets the following requirements:

WARNING! Please make sure you are opening your PR against master branch!

  • [ ] You have read the contributors guide
  • [ ] Pull Request title is properly formatted: KOGITO-XYZ Subject
  • [ ] Pull Request title contains the target branch if not targeting master: [0.9.x] KOGITO-XYZ Subject
  • [ ] Pull Request contains link to the JIRA issue
  • [ ] Pull Request contains link to any dependent or related Pull Request
  • [ ] Pull Request contains description of the issue
  • [ ] Pull Request does not include fixes for issues other than the main ticket
How to retest this PR or trigger a specific build:
  • Pull Request
    Please add comment: Jenkins retest this

  • Quarkus LTS checks
    Please add comment: Jenkins run LTS

  • Native checks
    Please add comment: Jenkins run native

bxf12315 avatar Jul 12 '21 15:07 bxf12315

@bxf12315 We can not use 'nightly' images at examples regarding it breaks the idea of maintain the stable branch. Is that correct @radtriste @cristianonicolai? Even It's true that to work at my local environment I need to use the 'nightly', I don't know what would be the good fix here.

nmirasch avatar Jul 12 '21 19:07 nmirasch

Indeed for now we can't as there is not automation to set back the released images on a release. https://issues.redhat.com/browse/KOGITO-5475 is there to change that but had no time to look into it for now ...

radtriste avatar Jul 13 '21 06:07 radtriste

@nmirasch correct, @bxf12315 we should not use nightly as it breaks the idea of stable branch.

cristianonicolai avatar Jul 13 '21 12:07 cristianonicolai

@nmirasch correct, @bxf12315 we should not use nightly as it breaks the idea of stable branch.

it's better way, but for now, kogito-examples are not work.

bxf12315 avatar Jul 13 '21 13:07 bxf12315

What is not working ? Those docker-compose should not be used in testing, they are just for user to test. master is not the default branch so it should not harm the user. Once that version is pushed to stable, the images should be released (note that 1.8 images are still not released due to infra problems, hopefully this will be solved for 1.9), so we don't need to use the nightly images on master

radtriste avatar Jul 13 '21 13:07 radtriste

What is not working ? Those docker-compose should not be used in testing, they are just for user to test. master is not the default branch so it should not harm the user. Once that version is pushed to stable, the images should be released (note that 1.8 images are still not released due to infra problems, hopefully this will be solved for 1.9), so we don't need to use the nightly images on master

all kogito apps will start, but we can not find any process instance in management-console and task-console, because of CORS issue of data-index. I think CORS issue fixed in nightly build.

bxf12315 avatar Jul 13 '21 13:07 bxf12315

I think the issue that @bxf12315 is trying to solve is related to the current docker image for data index, were the I think that { ̣isNull: true } query argument is not correctly working, this has been already fixed and the fix is present in the nightly images. I'd say that I won't add this change due to what's been already said.

pefernan avatar Jul 13 '21 18:07 pefernan

Closing as outdated

domhanak avatar Mar 01 '24 07:03 domhanak