incubator-hugegraph icon indicating copy to clipboard operation
incubator-hugegraph copied to clipboard

[Question] Dockerfile misc problems

Open aroundabout opened this issue 1 year ago • 1 comments

Problem Type (问题类型)

performance (性能优化) subtask of #840

Before submit

  • [X] 我已经确认现有的 IssuesFAQ 中没有相同 / 重复问题 (I have confirmed and searched that there are no similar problems in the historical issue and documents)

Environment (环境信息)

  • Server Version: 1.0.0 (Apache Release Version)
  • Backend: RocksDB x nodes, HDD or SSD
  • OS: xx CPUs, xx G RAM, Ubuntu 2x.x / CentOS 7.x
  • Data Size: xx vertices, xx edges

Your Question (问题描述)

In the current Dockerfile, we use a shell to run three shell in order:

ENTRYPOINT ["/usr/bin/dumb-init", "--"]
CMD ["./docker-entrypoint.sh"]

In docker-entrypoint.sh

./bin/wait-storage.sh
./bin/init-store.sh
./bin/start-hugegraph.sh -d false -j "$JAVA_OPTS" -g zgc

There are some question:

  1. Can the dumb-init work correctly or does it still make sense to use dumb-init
  2. If the server is down, will the container exit or not
  3. If the container is down, users should do what to restart the container? If they use docker start, docker will do wait-storage and init-store again. And if docker start, is the expected result consistent with the actual one?
  4. The name of docker-entrypoint.sh seems to be inappropriate

Vertex/Edge example (问题点 / 边数据举例)

No response

Schema [VertexLabel, EdgeLabel, IndexLabel] (元数据结构)

No response

aroundabout avatar Nov 08 '23 09:11 aroundabout

Due to the lack of activity, the current issue is marked as stale and will be closed after 20 days, any update will remove the stale label

github-actions[bot] avatar Nov 24 '23 21:11 github-actions[bot]