incubator-heron icon indicating copy to clipboard operation
incubator-heron copied to clipboard

Published 20 hours ago • verified publisher icon apache

Renamed variable but not updating the js

Open windhamwong opened this issue 2 years ago • 2 comments

https://github.com/apache/incubator-heron/blob/9cfc5c4785ba0c14d26dfbbf0fe1d6b477dd38a5/heron/tools/ui/resources/static/js/physical-plan.js#L55

Looks like the code containers[worker.stmgrId] is invalid because the stmgr ID has been renamed to worker.stmgr_id.

image

I am using /pull/3779 based on master, but the PR has no change to the code.

windhamwong avatar Mar 25 '22 15:03 windhamwong

Confirmed working if changing stmgrId to stmgr_id. See if anyone has the same issue, i have created PR

windhamwong avatar Mar 25 '22 15:03 windhamwong

This is currently being worked in #3786 . Feel free to submit any pull requests to that branch as we resolve the issues. There were many more broken aspects when we updated the code to support the newer Python versions.

nicknezis avatar Mar 26 '22 16:03 nicknezis

I believe this is now working with #3786 merged. Please re-open if it is still an issue.

nicknezis avatar Oct 14 '22 16:10 nicknezis