incubator-heron icon indicating copy to clipboard operation
incubator-heron copied to clipboard

Improve/clean up genproto rules

Open Code0x58 opened this issue 5 years ago • 0 comments

While upgrading to python3, the bazel protobuf rules took some coercing to get around https://github.com/protocolbuffers/protobuf/issues/1491. A better solution should be used to clean up code and improve stability†. It seems to me that these are options, by order of preference:

  • using standard protobuf bazel rules and their import_prefix
  • pursue https://github.com/protocolbuffers/protobuf/pull/7470
  • use relative paths in the protoc command so the imports are absolute (mentioned in issue)

† the build may flake due to files being removed while they are being iterated over

Code0x58 avatar Jul 07 '20 18:07 Code0x58