[GLUTEN-7664][VL][ARM] use arm64 triplet with vcpkg
What changes were proposed in this pull request?
Uses the arm64-linux triplet when building on arm64 with vcpkg. It uses the community triplet. Currently, vcpkg uses the x64-linux-avx triplet, with avx-specific instructions, which gives an error.
(Fixes: https://github.com/apache/incubator-gluten/issues/7664)
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename commit message and pull request title in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
https://github.com/apache/incubator-gluten/issues/7664
@z-anderson, we may need to create a file named arm64-linux.cmake like the below x64-linux-avx.cmake.
https://github.com/apache/incubator-gluten/blob/main/dev/vcpkg/triplets/x64-linux-avx.cmake
@guyuqi would you have a try?
@z-anderson thanks for the improvement, could you please share which platform are you running? aarch64 arm64 seems different architectures
-yuan
@zhouyuan I'm using aarch64, but I see triplets defined for arm64 (not for aarch64), so I think the triplet is supposed to be for arm64 https://github.com/microsoft/vcpkg/tree/master/triplets
@zhouyuan I'm using aarch64, but I see triplets defined for arm64 (not for aarch64), so I think the triplet is supposed to be for arm64 https://github.com/microsoft/vcpkg/tree/master/triplets
Also note valid target architectures allowed for vcpkg: see link. I guess arm64 is suitable for aarch64.
Looks like arm64 is used by apple and aarch64 is by others. They are the same. @guyuqi
Looks like arm64 is used by apple and aarch64 is by others. They are the same. @guyuqi
Arm64 and aarch64 are often used interchangeably and they just have slight differences.
aarch64 is used more precisely in the context of low-level programming, compiler settings, and technical specifications.
Arm64 is used more in the context of discussing ARM's architecture in general, especially in marketing and broader technical discussions.
And on most Linux distributions, the "arch" command returns "aarch64", while on Apple M series systems, the "arch" command returns "arm64".
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.
This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.