incubator-gluten icon indicating copy to clipboard operation
incubator-gluten copied to clipboard

[GLUTEN-7664][VL][ARM] use arm64 triplet with vcpkg

Open z-anderson opened this issue 1 year ago • 3 comments

What changes were proposed in this pull request?

Uses the arm64-linux triplet when building on arm64 with vcpkg. It uses the community triplet. Currently, vcpkg uses the x64-linux-avx triplet, with avx-specific instructions, which gives an error.

(Fixes: https://github.com/apache/incubator-gluten/issues/7664)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

z-anderson avatar Oct 25 '24 18:10 z-anderson

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

github-actions[bot] avatar Oct 25 '24 18:10 github-actions[bot]

https://github.com/apache/incubator-gluten/issues/7664

github-actions[bot] avatar Oct 25 '24 18:10 github-actions[bot]

@z-anderson, we may need to create a file named arm64-linux.cmake like the below x64-linux-avx.cmake. https://github.com/apache/incubator-gluten/blob/main/dev/vcpkg/triplets/x64-linux-avx.cmake

PHILO-HE avatar Oct 26 '24 03:10 PHILO-HE

@guyuqi would you have a try?

FelixYBW avatar Oct 26 '24 23:10 FelixYBW

@z-anderson thanks for the improvement, could you please share which platform are you running? aarch64 arm64 seems different architectures

-yuan

zhouyuan avatar Oct 28 '24 01:10 zhouyuan

@zhouyuan I'm using aarch64, but I see triplets defined for arm64 (not for aarch64), so I think the triplet is supposed to be for arm64 https://github.com/microsoft/vcpkg/tree/master/triplets

z-anderson avatar Oct 29 '24 13:10 z-anderson

@zhouyuan I'm using aarch64, but I see triplets defined for arm64 (not for aarch64), so I think the triplet is supposed to be for arm64 https://github.com/microsoft/vcpkg/tree/master/triplets

Also note valid target architectures allowed for vcpkg: see link. I guess arm64 is suitable for aarch64.

PHILO-HE avatar Oct 29 '24 13:10 PHILO-HE

Looks like arm64 is used by apple and aarch64 is by others. They are the same. @guyuqi

FelixYBW avatar Oct 29 '24 18:10 FelixYBW

Looks like arm64 is used by apple and aarch64 is by others. They are the same. @guyuqi

Arm64 and aarch64 are often used interchangeably and they just have slight differences.

aarch64 is used more precisely in the context of low-level programming, compiler settings, and technical specifications. Arm64 is used more in the context of discussing ARM's architecture in general, especially in marketing and broader technical discussions.

And on most Linux distributions, the "arch" command returns "aarch64", while on Apple M series systems, the "arch" command returns "arm64".

guyuqi avatar Oct 30 '24 06:10 guyuqi

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Dec 15 '24 02:12 github-actions[bot]

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.

github-actions[bot] avatar Dec 26 '24 01:12 github-actions[bot]