incubator-gluten icon indicating copy to clipboard operation
incubator-gluten copied to clipboard

[GLUTEN-7641][VL] Add Gluten benchmark scripts

Open marin-ma opened this issue 1 year ago • 6 comments

marin-ma avatar Oct 22 '24 12:10 marin-ma

https://github.com/apache/incubator-gluten/issues/7641

github-actions[bot] avatar Oct 22 '24 12:10 github-actions[bot]

Thank you!

BTW there were a couple of related efforts in our code base (not all of them):

https://github.com/apache/incubator-gluten/pull/432 https://github.com/apache/incubator-gluten/pull/5278

Should we review them then remove the unnecessary / unmaintained ones? If they are still needed, I think we can create a new directory like examples to centralize them.

zhztheplayer avatar Oct 23 '24 02:10 zhztheplayer

Why there are 3 TPCDS queries set? Can we consolidate to one?

./tools/gluten-it/common/src/main/resources/tpcds-queries ./gluten-core/src/test/resources/tpcds-queries ./gluten-core/target/scala-2.12/test-classes/tpcds-queries

FelixYBW avatar Oct 23 '24 04:10 FelixYBW

Thank you!

BTW there were a couple of related efforts in our code base (not all of them):

#432 #5278

Should we review them then remove the unnecessary / unmaintained ones? If they are still needed, I think we can create a new directory like examples to centralize them.

We may put it under tools/workload, name it as benchmark_velox since the script only support Velox.

FelixYBW avatar Oct 23 '24 04:10 FelixYBW

Why there are 3 TPCDS queries set? Can we consolidate to one?

./tools/gluten-it/common/src/main/resources/tpcds-queries ./gluten-core/src/test/resources/tpcds-queries ./gluten-core/target/scala-2.12/test-classes/tpcds-queries

@FelixYBW ./gluten-core/target/scala-2.12/test-classes/tpcds-queries is generated by maven compile time. It's not in the code base.

./tools/gluten-it/common/src/main/resources/tpcds-queries is the one used by GHA and notebook scripts ./gluten-core/src/test/resources/tpcds-queries Not sure if this one is used by any Gluten UT. I will double check. If not, we can remove it.

marin-ma avatar Oct 23 '24 05:10 marin-ma

@FelixYBW Opened https://github.com/apache/incubator-gluten/pull/7666 for some removals.

backends-velox/src/test/resources/tpch-queries-velox should also be removed. I will open another PR to remove them.

marin-ma avatar Oct 24 '24 12:10 marin-ma

initialize.ipynb. Let's remove the BKM section

FelixYBW avatar Nov 14 '24 01:11 FelixYBW

Looks good. Let's test on cloud once we have a chance.

FelixYBW avatar Nov 14 '24 02:11 FelixYBW