incubator-gluten icon indicating copy to clipboard operation
incubator-gluten copied to clipboard

[GLUTEN-7532][CORE] Rewrite TakeOrderedAndProject as actually executed operators when do offload

Open ivoson opened this issue 1 year ago • 9 comments

What changes were proposed in this pull request?

Rewrite the TakeOrderedAndProjectExecTransformer to the operators which are actually executed when do offload. Currently, the logic is wrapped in the RDD of the operator. Which means that in the RDD computation we play with the sql operators to generate new RDDs which is not a common practice processing sql queries. And the final executed plan and metrics information won't be shown correctly in the Spark UI page.

In this PR, rewrite the node TakeOrderedAndProjectExecTransformer when do offload so that the operators can be shown correctly.

How was this patch tested?

UT

ivoson avatar Oct 15 '24 03:10 ivoson

https://github.com/apache/incubator-gluten/issues/7532

github-actions[bot] avatar Oct 15 '24 03:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 15 '24 03:10 github-actions[bot]

+1 to the idea. I remember there was vanilla Spark limitation as blocker against a similar effort. But let's see if it's doable at this time.

zhztheplayer avatar Oct 15 '24 03:10 zhztheplayer

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 15 '24 09:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 16 '24 09:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 17 '24 09:10 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 17 '24 09:10 github-actions[bot]

cc @zhztheplayer can you please review this PR? Thanks.

ivoson avatar Oct 18 '24 02:10 ivoson

Run Gluten Clickhouse CI

github-actions[bot] avatar Oct 25 '24 09:10 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Dec 15 '24 02:12 github-actions[bot]

This PR was auto-closed because it has been stalled for 10 days with no activity. Please feel free to reopen if it is still valid. Thanks.

github-actions[bot] avatar Dec 26 '24 01:12 github-actions[bot]