incubator-gluten icon indicating copy to clipboard operation
incubator-gluten copied to clipboard

[GLUTEN-7078][CORE] The fallback check for Scan should not be skipped when DPP is present

Open wang-zhun opened this issue 1 year ago • 7 comments

What changes were proposed in this pull request?

(Fixes: #7078) performing fallback detection for Scan in advance is good and does not introduce any side effects.

How was this patch tested?

manual tests

wang-zhun avatar Sep 02 '24 07:09 wang-zhun

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

github-actions[bot] avatar Sep 02 '24 07:09 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Sep 02 '24 07:09 github-actions[bot]

https://github.com/apache/incubator-gluten/issues/7078

github-actions[bot] avatar Sep 02 '24 08:09 github-actions[bot]

it better to add some ut for this scenario.

zzcclp avatar Sep 02 '24 10:09 zzcclp

it better to add some ut for this scenario.

ok, thank you for the response.

wang-zhun avatar Sep 02 '24 10:09 wang-zhun

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Oct 18 '24 01:10 github-actions[bot]

Do we have any updates on this PR?

zhztheplayer avatar Oct 18 '24 02:10 zhztheplayer

I think the if conditions are no longer needed after clean up https://github.com/apache/incubator-gluten/pull/6035? Let's merge to see if everything goes fine. cc @zzcclp

zhztheplayer avatar Nov 12 '24 06:11 zhztheplayer