incubator-gluten icon indicating copy to clipboard operation
incubator-gluten copied to clipboard

Why still build arrow when --enable_ep_cache=ON

Open j7nhai opened this issue 1 year ago • 2 comments

Problem description

If someone enable_ep_cache, he/she may don't want to build arrow.

System information

image

CMake log

No response

j7nhai avatar Jul 05 '24 11:07 j7nhai

fix on #6351

j7nhai avatar Jul 05 '24 11:07 j7nhai

I think enable_ep_cache is just for controlling velox ep. Arrow build/installation can be categorized to Gluten dependency setup, though we have no such overall control for dependency setup by now.

PHILO-HE avatar Jul 05 '24 12:07 PHILO-HE

I think enable_ep_cache is just for controlling velox ep. Arrow build/installation can be categorized to Gluten dependency setup, though we have no such overall control for dependency setup by now.

Okay, Maybe it's better to add --build_arrow=OFF when only gluten code change when we develop?

image

j7nhai avatar Jul 09 '24 13:07 j7nhai

@j7nhai, yes, generally only first time build needs to build arrow. Arrow code and build option are not changed after installation, unless we upgrade it or need to apply some other patches to arrow source code. I will update the doc. Thanks!

PHILO-HE avatar Jul 09 '24 13:07 PHILO-HE

@j7nhai, yes, generally only first time build needs to build arrow. Arrow code and build option are not changed after installation, unless we upgrade it or need to apply some other patches to arrow source code. I will update the doc. Thanks!

OK.

j7nhai avatar Jul 09 '24 13:07 j7nhai