[VL] Add Scala 2.13 support
What changes were proposed in this pull request?
Add Scala 2.13 support
(Fixes: #6316)
How was this patch tested?
Build locally
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename commit message and pull request title in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI
@zhztheplayer Could you please review this PR? Thanks!
Prior to Spark 4.0, Scala 2.13 was not the default Scala version, and I personally do not recommend supporting it for Spark 3.x.
Thanks @LuciferYang, I think Scala 2.13 support is already added for CH backend, plan was to extend to VL backend as well, since the build fails when you enable -Pbackends-velox -Pscala-2.13, that was the plan, does that make sense.
FYI, the support for Scala 2.13 was added here already - #6311
cc: @zhztheplayer
@Preetesh2110 please take a look at failing CI and maybe also add a CI option to build with Scala 2.13
Thanks @LuciferYang, I think Scala 2.13 support is already added for CH backend, plan was to extend to VL backend as well, since the build fails when you enable
-Pbackends-velox -Pscala-2.13, that was the plan, does that make sense.FYI, the support for Scala 2.13 was added here already - #6311
cc: @zhztheplayer
Got
Run Gluten Clickhouse CI
thanks @surnaik. fixed the scala Style issues.
Do we need to have a test for Scala 2.13 (with Spark 3.5 probably) ? https://github.com/apache/incubator-gluten/blob/main/.github/workflows/velox_docker.yml
Run Gluten Clickhouse CI
Thanks for the feedback. I have added a workflow @zhztheplayer.
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI
@Preetesh2110 Please fix the CI failures
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI
Run Gluten Clickhouse CI