incubator-gluten icon indicating copy to clipboard operation
incubator-gluten copied to clipboard

[VL] Add Scala 2.13 support

Open Preetesh2110 opened this issue 1 year ago • 5 comments

What changes were proposed in this pull request?

Add Scala 2.13 support

(Fixes: #6316)

How was this patch tested?

Build locally

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Preetesh2110 avatar Jul 03 '24 09:07 Preetesh2110

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

github-actions[bot] avatar Jul 03 '24 09:07 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 03 '24 09:07 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 03 '24 13:07 github-actions[bot]

@zhztheplayer Could you please review this PR? Thanks!

surnaik avatar Jul 04 '24 07:07 surnaik

Prior to Spark 4.0, Scala 2.13 was not the default Scala version, and I personally do not recommend supporting it for Spark 3.x.

LuciferYang avatar Jul 04 '24 07:07 LuciferYang

Thanks @LuciferYang, I think Scala 2.13 support is already added for CH backend, plan was to extend to VL backend as well, since the build fails when you enable -Pbackends-velox -Pscala-2.13, that was the plan, does that make sense.

FYI, the support for Scala 2.13 was added here already - #6311

cc: @zhztheplayer

surnaik avatar Jul 08 '24 06:07 surnaik

@Preetesh2110 please take a look at failing CI and maybe also add a CI option to build with Scala 2.13

surnaik avatar Jul 08 '24 06:07 surnaik

Thanks @LuciferYang, I think Scala 2.13 support is already added for CH backend, plan was to extend to VL backend as well, since the build fails when you enable -Pbackends-velox -Pscala-2.13, that was the plan, does that make sense.

FYI, the support for Scala 2.13 was added here already - #6311

cc: @zhztheplayer

Got

LuciferYang avatar Jul 09 '24 11:07 LuciferYang

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 10 '24 05:07 github-actions[bot]

thanks @surnaik. fixed the scala Style issues.

Preetesh2110 avatar Jul 10 '24 07:07 Preetesh2110

Do we need to have a test for Scala 2.13 (with Spark 3.5 probably) ? https://github.com/apache/incubator-gluten/blob/main/.github/workflows/velox_docker.yml

zhztheplayer avatar Jul 11 '24 01:07 zhztheplayer

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 11 '24 05:07 github-actions[bot]

Thanks for the feedback. I have added a workflow @zhztheplayer.

Preetesh2110 avatar Jul 11 '24 09:07 Preetesh2110

Run Gluten Clickhouse CI

zhztheplayer avatar Jul 12 '24 00:07 zhztheplayer

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 12 '24 02:07 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 12 '24 05:07 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 12 '24 09:07 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 12 '24 09:07 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 12 '24 13:07 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 12 '24 19:07 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 13 '24 06:07 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 13 '24 14:07 github-actions[bot]

@Preetesh2110 Please fix the CI failures

surnaik avatar Jul 29 '24 03:07 surnaik

Run Gluten Clickhouse CI

github-actions[bot] avatar Aug 04 '24 06:08 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Aug 04 '24 15:08 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Aug 05 '24 06:08 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Aug 05 '24 10:08 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Aug 05 '24 10:08 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Aug 05 '24 10:08 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Aug 05 '24 15:08 github-actions[bot]