incubator-gluten icon indicating copy to clipboard operation
incubator-gluten copied to clipboard

[GLUTEN-6285][VL] Add debian10 vcpkg depends

Open wenwj0 opened this issue 1 year ago • 6 comments

What changes were proposed in this pull request?

Add debian 10 support in vcpkg depends.

(Please fill in changes proposed in this fix)

(Fixes: #ISSUE-ID) #6285

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

wenwj0 avatar Jun 30 '24 02:06 wenwj0

https://github.com/apache/incubator-gluten/issues/6285

github-actions[bot] avatar Jun 30 '24 02:06 github-actions[bot]

We don't have CI to track this. Would you like to maintain this support?

FelixYBW avatar Jul 01 '24 18:07 FelixYBW

We don't have CI to track this. Would you like to maintain this support?

@FelixYBW Sure, I am willing to do this, please let me know what I need to do.

wenwj0 avatar Jul 02 '24 02:07 wenwj0

@wenwj0, this patch has been verified on debian 10, right?

PHILO-HE avatar Jul 04 '24 06:07 PHILO-HE

@PHILO-HE Yes, I have successfully verified this on Debian 10 docker, and deployed it on my cluster.

wenwj0 avatar Jul 04 '24 13:07 wenwj0

@wenwj0, please rebase the code. Will merge this patch if no CI failure. Thanks!

PHILO-HE avatar Jul 05 '24 04:07 PHILO-HE

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_07_08_2024_time.csv log/native_master_07_07_2024_0cb2db3b7_time.csv difference percentage
q1 34.69 35.76 1.067 103.08%
q2 23.85 23.16 -0.682 97.14%
q3 38.33 41.25 2.927 107.64%
q4 31.32 32.52 1.202 103.84%
q5 68.03 70.16 2.132 103.13%
q6 7.70 11.02 3.323 143.15%
q7 80.37 79.64 -0.728 99.09%
q8 84.50 86.29 1.782 102.11%
q9 124.34 121.32 -3.021 97.57%
q10 48.36 47.36 -1.003 97.93%
q11 20.16 19.77 -0.388 98.07%
q12 28.04 24.54 -3.505 87.50%
q13 37.95 41.42 3.470 109.14%
q14 20.41 18.15 -2.256 88.94%
q15 29.61 33.66 4.048 113.67%
q16 14.78 14.56 -0.221 98.50%
q17 101.16 103.05 1.891 101.87%
q18 147.36 144.75 -2.608 98.23%
q19 13.95 14.82 0.875 106.27%
q20 30.49 31.94 1.450 104.76%
q21 263.82 261.73 -2.087 99.21%
q22 12.64 11.99 -0.655 94.82%
total 1261.86 1268.88 7.013 100.56%

GlutenPerfBot avatar Jul 08 '24 17:07 GlutenPerfBot