incubator-gluten icon indicating copy to clipboard operation
incubator-gluten copied to clipboard

[GLUTEN-6202][VL] No extra SortExec needed before WindowExec if window type is `sort`

Open WangGuangxin opened this issue 1 year ago • 11 comments

What changes were proposed in this pull request?

When spark.gluten.sql.columnar.backend.velox.window.type is set to sort, there should be no extra SortExec before WindowExec in plan.

(Fixes: #6202)

How was this patch tested?

Mannual Test and UT

WangGuangxin avatar Jun 25 '24 00:06 WangGuangxin

https://github.com/apache/incubator-gluten/issues/6202

github-actions[bot] avatar Jun 25 '24 00:06 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jun 25 '24 00:06 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jun 25 '24 00:06 github-actions[bot]

cc @JkSelf

WangGuangxin avatar Jun 25 '24 00:06 WangGuangxin

Run Gluten Clickhouse CI

github-actions[bot] avatar Jun 25 '24 02:06 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jun 26 '24 00:06 github-actions[bot]

And CH CI failed https://opencicd.kyligence.com/job/gluten/job/gluten-ci/10302/, please also take a look. Thanks.

zhztheplayer avatar Jun 26 '24 02:06 zhztheplayer

Run Gluten Clickhouse CI

github-actions[bot] avatar Jun 26 '24 03:06 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 02 '24 14:07 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 02 '24 14:07 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Jul 03 '24 00:07 github-actions[bot]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days.

github-actions[bot] avatar Aug 17 '24 01:08 github-actions[bot]