incubator-gluten icon indicating copy to clipboard operation
incubator-gluten copied to clipboard

[VL] Support regr_r2 aggregate function

Open liujiayi771 opened this issue 1 year ago • 4 comments

What changes were proposed in this pull request?

Support regr_r2 aggregate function.

How was this patch tested?

Add new test case in VeloxAggregateFunctionsSuite

liujiayi771 avatar Mar 29 '24 14:03 liujiayi771

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

github-actions[bot] avatar Mar 29 '24 14:03 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Mar 29 '24 14:03 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Mar 29 '24 14:03 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Mar 29 '24 15:03 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Mar 30 '24 01:03 github-actions[bot]

cc @rui-mo @PHILO-HE, thanks.

liujiayi771 avatar Apr 01 '24 01:04 liujiayi771

Run Gluten Clickhouse CI

github-actions[bot] avatar Apr 01 '24 07:04 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Apr 01 '24 07:04 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Apr 01 '24 08:04 github-actions[bot]

If the CH failed tests are the ones just fixed by 131f700, we can ignore the failure.

Yes, we can ignore the failure.

[2024-04-01T09:30:12.651Z] - test mergetree table write *** FAILED ***
[2024-04-01T09:30:12.651Z]   org.apache.spark.SparkException: Job aborted.
[2024-04-01T09:30:12.651Z]   at org.apache.spark.sql.errors.QueryExecutionErrors$.jobAbortedError(QueryExecutionErrors.scala:651)
[2024-04-01T09:30:12.651Z]   at org.apache.spark.sql.execution.datasources.v1.clickhouse.MergeTreeFileFormatWriter$.write(MergeTreeFileFormatWriter.scala:252)
[2024-04-01T09:30:12.651Z]   at org.apache.spark.sql.delta.ClickhouseOptimisticTransaction.$anonfun$writeFiles$1(ClickhouseOptimisticTransaction.scala:124)
[2024-04-01T09:30:12.651Z]   at org.apache.spark.sql.execution.SQLExecution$.$anonfun$withNewExecutionId$6(SQLExecution.scala:109)
[2024-04-01T09:30:12.651Z]   at org.apache.spark.sql.execution.SQLExecution$.withSQLConfPropagated(SQLExecution.scala:169)
[2024-04-01T09:30:12.651Z]   at org.apache.spark.sql.execution.SQLExecution$.$anonfun$withNewExecutionId$1(SQLExecution.scala:95)
[2024-04-01T09:30:12.651Z]   at org.apache.spark.sql.SparkSession.withActive(SparkSession.scala:779)
[2024-04-01T09:30:12.651Z]   at org.apache.spark.sql.execution.SQLExecution$.withNewExecutionId(SQLExecution.scala:64)
[2024-04-01T09:30:12.651Z]   at org.apache.spark.sql.delta.ClickhouseOptimisticTransaction.writeFiles(ClickhouseOptimisticTransaction.scala:76)
[2024-04-01T09:30:12.651Z]   at org.apache.spark.sql.delta.files.TransactionalWrite.writeFiles(TransactionalWrite.scala:212)

liujiayi771 avatar Apr 01 '24 09:04 liujiayi771