incubator-gluten icon indicating copy to clipboard operation
incubator-gluten copied to clipboard

[CORE] Restore the function signature for eliminateProjectList

Open liujiayi771 opened this issue 1 year ago • 3 comments

What changes were proposed in this pull request?

Because we still need to append the pulled-out NamedExpressions after the child output, it would be more appropriate to revert back to the original function signature.

How was this patch tested?

Exists CI tests.

liujiayi771 avatar Mar 29 '24 01:03 liujiayi771

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

github-actions[bot] avatar Mar 29 '24 01:03 github-actions[bot]

Run Gluten Clickhouse CI

github-actions[bot] avatar Mar 29 '24 01:03 github-actions[bot]

Hi @zhli1142015. If we still need to append the pulled-out NamedExpressions after the child output to maintain the order of the project list in the existing golden file tests without modification, I think it would be better to revert back to the original function signature to clearly express that the second parameter "appends after" the first parameter.

liujiayi771 avatar Mar 29 '24 01:03 liujiayi771

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5191_time.csv log/native_master_03_29_2024_3b9a3ea09_time.csv difference percentage
q1 36.28 37.97 1.688 104.65%
q2 24.64 23.84 -0.806 96.73%
q3 37.09 37.86 0.766 102.06%
q4 38.30 39.36 1.061 102.77%
q5 69.70 69.59 -0.109 99.84%
q6 7.25 7.34 0.090 101.24%
q7 82.14 83.01 0.874 101.06%
q8 88.45 86.59 -1.858 97.90%
q9 119.79 122.44 2.653 102.21%
q10 43.46 46.69 3.225 107.42%
q11 20.85 20.70 -0.147 99.29%
q12 23.81 27.11 3.302 113.87%
q13 46.90 47.43 0.533 101.14%
q14 19.20 20.04 0.842 104.38%
q15 29.96 30.81 0.844 102.82%
q16 15.85 14.26 -1.583 90.01%
q17 100.81 101.05 0.238 100.24%
q18 140.25 141.33 1.079 100.77%
q19 15.75 15.32 -0.440 97.21%
q20 26.75 27.29 0.540 102.02%
q21 226.06 230.77 4.707 102.08%
q22 14.14 13.96 -0.175 98.76%
total 1227.44 1244.76 17.322 101.41%

GlutenPerfBot avatar Mar 30 '24 02:03 GlutenPerfBot