incubator-gluten icon indicating copy to clipboard operation
incubator-gluten copied to clipboard

[OPPRO-277] Support Math functions in Gluten

Open zhixingheyi-tian opened this issue 2 years ago • 3 comments

What changes were proposed in this pull request?

Also include String function chr() support.

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

zhixingheyi-tian avatar Oct 18 '22 08:10 zhixingheyi-tian

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[Gluten-${ISSUES_ID}] ${detailed message}

See also:

github-actions[bot] avatar Oct 18 '22 08:10 github-actions[bot]

@zhixingheyi-tian can you create an issue in issue list or internal issue tracker?

FelixYBW avatar Oct 18 '22 19:10 FelixYBW

@zhixingheyi-tian can you create an issue in issue list or internal issue tracker?

Have created corresponding Jira. Thanks

zhixingheyi-tian avatar Oct 19 '22 06:10 zhixingheyi-tian

@zzcclp Do you have any comment?

rui-mo avatar Oct 21 '22 07:10 rui-mo

Please rebase and re-test.

Also move test case to gluten-ut module ? After CH Backend supports these expression and reuse test cases.

zzcclp avatar Oct 21 '22 13:10 zzcclp

Please rebase and re-test.

Also move test case to gluten-ut module ? After CH Backend supports these expression and reuse test cases.

Have re-tested.

Similar here: https://github.com/oap-project/gluten/pull/451#discussion_r1002297910. Can in another PR.

zhixingheyi-tian avatar Oct 24 '22 05:10 zhixingheyi-tian

LGTM

Thanks

zhixingheyi-tian avatar Oct 24 '22 05:10 zhixingheyi-tian

Please rebase and re-test. Also move test case to gluten-ut module ? After CH Backend supports these expression and reuse test cases.

Have re-tested.

Similar here: #451 (comment). Can in another PR.

OK, I will do this after supporting these functions for ClickHouse

zzcclp avatar Oct 24 '22 05:10 zzcclp