incubator-gluten
incubator-gluten copied to clipboard
[OPPRO-277] Support Math functions in Gluten
What changes were proposed in this pull request?
Also include String function chr() support.
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/oap-project/gluten/issues
Then could you also rename commit message and pull request title in the following format?
[Gluten-${ISSUES_ID}] ${detailed message}
See also:
@zhixingheyi-tian can you create an issue in issue list or internal issue tracker?
@zhixingheyi-tian can you create an issue in issue list or internal issue tracker?
Have created corresponding Jira. Thanks
@zzcclp Do you have any comment?
Please rebase and re-test.
Also move test case to gluten-ut module ? After CH Backend supports these expression and reuse test cases.
Please rebase and re-test.
Also move test case to gluten-ut module ? After CH Backend supports these expression and reuse test cases.
Have re-tested.
Similar here: https://github.com/oap-project/gluten/pull/451#discussion_r1002297910. Can in another PR.
LGTM
Thanks
Please rebase and re-test. Also move test case to gluten-ut module ? After CH Backend supports these expression and reuse test cases.
Have re-tested.
Similar here: #451 (comment). Can in another PR.
OK, I will do this after supporting these functions for ClickHouse