incubator-devlake
incubator-devlake copied to clipboard
apache
[Bug][Dora Metrics] Date Range for Benchmarks(Performance Levels) of Deployment Frequency is not correct.
Search before asking
- [X] I had searched in the issues and found no similar issues.
What happened
I was trying to understand in a better way the Benchmarks for Deployment Frequency. As a part of the learning/testing put the all steps separated in tables, then I select a different time range from August 2023 to September 2023. However, the tables for the calculation still picking the date range from August 2023 until Today.
As you can see during August to September we have deployments therefore at least the Deployment Frequency should be "one per month and once every 6 months" and not "Fewer than once per six months".
What do you expect to happen
The date range for deployment frequency benchmarks should follow the date filter that the user selects in the dashboard, and not be set to in SYSDATE().
How to reproduce
Bug
Anything else
Possible solution:
Version
v0.19.0-rc4@
Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
I think you are right. I am not sure why DevLake use SYSDATE instead of $__timeTo.
cc @Startrekzky
Good morning @d4x1, I also created tables for all the steps of the Benchmarks(Performance Levels) of Deployment Frequency, and as you can see here, all of them use the wrong date range. In this case the date range should be just June.
And here, you can see the difference using $__timeTo. Date range just June .
It's because I wanted to fixate the date range to six months as measuring DORA metrics in a short time period will be less effective. That's why I wrote this way. I've considered using your solution in the first place, but I forgot why I chose the current way. What are your thoughts on this, should we change it? @abeizn
Cc. @d4x1
@estefaniasuasti Thanks, very good suggestion, we will revamp it in the v1.0 version. cc @Startrekzky @d4x1
