[Bug][Config UI] Tries to update both PAT and GitHub App when moving connection from one to the other

[nathan-nicholson]

Search before asking

• [X] I had searched in the issues and found no similar issues.

What happened

When I was switching my GitHub connection from a PAT to a GitHub app, I was getting error messages from the UI. Looking at the network requests and I was getting 500 Internal Server errors without any actionable info.

I noticed that my PAT was still in the request body even though I had the GitHub App radio button selected. That struck me as being odd.

After selecting "GitHub Token" and removing the configured PAT and going back to the "GitHub App", the request went through and the connection was successfully updated.

What do you expect to happen

That the connection would have been updated with my GitHub App info, overriding the PAT configuration that was already there.

How to reproduce

1. Configure a GitHub Connection with a PAT and save it
2. Edit the GitHub Connection again
3. Select the GitHub App radio button without removing the PAT
4. Fill the requisite credentials to a valid GitHub app
5. Try to save the configuration
6. See generic error message

Anything else

No response

Version

v0.18.0

Are you willing to submit PR?

• [ ] Yes I am willing to submit a PR!

Code of Conduct

• [X] I agree to follow this project's Code of Conduct

[abeizn]

@mintsweet

[github-actions[bot]]

This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.

[github-actions[bot]]

This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.

[github-actions[bot]]

This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.

[github-actions[bot]]

This issue has been closed because it has been inactive for a long time. You can reopen it if you encounter the similar problem in the future.