incubator-devlake icon indicating copy to clipboard operation
incubator-devlake copied to clipboard

[Bug][UI] "RangeError: Maximum call stack size exceeded" when adding a Data Scope

Open mbravorus opened this issue 2 years ago • 6 comments

Search before asking

  • [X] I had searched in the issues and found no similar issues.

What happened

When adding a Data Scope on a Github connection to a Github Enterprise Server v3.8, and clicking on a git org which contains many repos (over a thousand), I receive the error "RangeError: Maximum call stack size exceeded". I have tried this with GraphQL on and off, it doesn't matter.

image

What do you expect to happen

I expect to see a list of the repositories in the right-hand box and be able to select the ones I need

How to reproduce

Connect to a Github installation (checked only on a server, not entirely sure if Github Cloud behaves the same), ensure it has a git org with more than a thousand repos, and attempt to add a data scope for that org

Anything else

Happens every time

Version

v0.18.0

Are you willing to submit PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

mbravorus avatar Oct 10 '23 13:10 mbravorus

hi @mbravorus , thank you for your feedback.

We have received a lot of feedback about this issue, but have not been able to successfully reproduce it. I will continue to pay attention to this issue. Thank you.

mintsweet avatar Oct 12 '23 03:10 mintsweet

#5680

mintsweet avatar Oct 12 '23 03:10 mintsweet

Would you mind sharing a screen-recording video for further investigation? Thanks

klesh avatar Oct 12 '23 03:10 klesh

sure, please find attached

https://github.com/apache/incubator-devlake/assets/593723/9521a57f-46ef-4730-a347-3a3570e03882

mbravorus avatar Oct 12 '23 09:10 mbravorus

This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Dec 12 '23 00:12 github-actions[bot]

This issue has been automatically marked as stale because it has been inactive for 60 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Feb 11 '24 00:02 github-actions[bot]

Hello there, I am experiencing the same problem and I am running v0.21.0-beta4. Seems like that issue is not related to the number of projects in a group. I have two groups with 46 projects each, and one of them I was able to import and the other group I was not. Also the issue seems to be with rendering the results, cause if I open the endpoint that it tries to reach, https://devlakeendpooint.net/api/plugins/gitlab/connections/1/remote-scopes?groupId=XX works as expected and I receive the projects in a json format. Thanks.

kirestamenov avatar Feb 29 '24 08:02 kirestamenov

hi @kirestamenov, your guess is correct. I need specific data to help me reproduce this issue. Can you provide it?

mintsweet avatar Feb 29 '24 08:02 mintsweet

hey @mintsweet what kind of data do you need, can you be more specific please? FYI: all repos are part of self-managed gitlab server

kirestamenov avatar Feb 29 '24 10:02 kirestamenov

Hi @kirestamenov, sorry for not making it clear, I need what the API returns when this error occurs.

image

mintsweet avatar Mar 01 '24 01:03 mintsweet

Hey @mintsweet, please find attached the response from the endpoint I mentioned above. I had to mask some of the data masked_error_response.json

kirestamenov avatar Mar 01 '24 11:03 kirestamenov

Hi @kirestamenov, thank you for your data. I'll check it today.

mintsweet avatar Mar 04 '24 02:03 mintsweet

Hello,

I've encountered the same issue as described here. Previously, I was using v0.21.0-beta1. To try and solve the problem, I upgraded to v0.21.0-beta6, but unfortunately, the issue persists. Could anyone provide guidance on whether it's possible to resolve this? The problem doesn't occur in all projects, but so far, I'm unable to determine what might be causing it.

Any insights or suggestions would be greatly appreciated.

Thank you. Снимок экрана 2024-03-05 в 00 20 05

Dimatime avatar Mar 04 '24 21:03 Dimatime

Hi, @kirestamenov, thank you for your data, I'll fix this issue soon.

Hi, @Dimatime, this issue will be fixed soon, please wait patiently.

mintsweet avatar Mar 05 '24 07:03 mintsweet

@mintsweet Thank you for your prompt response and quick attention to our request! We greatly appreciate your focus on our inquiry. We are eagerly looking forward to the release. Thank you for your efforts and support!

Dimatime avatar Mar 05 '24 07:03 Dimatime

hey @mintsweet,

we just deployed v0.21.0-beta7 and everything works as expected. Thanks a lot for immediate action on this. Much appreciated. Thanks a bunch

kirestamenov avatar Mar 11 '24 09:03 kirestamenov

@kirestamenov I'm so glad to help you.

mintsweet avatar Mar 11 '24 09:03 mintsweet