incubator-devlake icon indicating copy to clipboard operation
incubator-devlake copied to clipboard

[Feature][frame] transformationRules has set default value.

Open abeizn opened this issue 2 years ago • 1 comments

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Description

Should the backend remove these default handling?

image image

Use case

No response

Related issues

No response

Are you willing to submit a PR?

  • [ ] Yes I am willing to submit a PR!

Code of Conduct

abeizn avatar Sep 20 '22 13:09 abeizn

For most of cases, users might use the same rules as shown, so I think maybe we can keep these rules. If users want to utilize their own rules, they will define by themselves, otherwise, why not give them default value?

warren830 avatar Sep 21 '22 03:09 warren830

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Oct 22 '22 00:10 github-actions[bot]

However, it is quite confusing for users, they would get an unexpected result when they set the options to empty.

klesh avatar Oct 25 '22 01:10 klesh

I added this to v0.15 and we should discuss this matter. @Startrekzky @yumengwang03

klesh avatar Oct 25 '22 01:10 klesh

@warren830 I'm not against providing reasonable default values to users. But I think the key issue here is that the current frontend presentation would lead users to believe those values are just placeholders, instead of default values, thus resulting in the mismatch of the frontend and backend behavior.

If we keep the frontend unchanged, I will vote for removing those default values in the backend as well.

hezyin avatar Oct 27 '22 22:10 hezyin

I agree with @hezyin and I created issue #3675 for providing reasonable default values. I need some time to finish the default values for each plugin though, and the default values should be shown in the Config UI form fields.

Startrekzky avatar Nov 04 '22 07:11 Startrekzky

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Dec 30 '22 00:12 github-actions[bot]

This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.

github-actions[bot] avatar Jan 06 '23 00:01 github-actions[bot]