incubator-devlake
incubator-devlake copied to clipboard
[Feature][frame] transformationRules has set default value.
Search before asking
- [X] I had searched in the issues and found no similar feature requirement.
Description
Should the backend remove these default handling?
Use case
No response
Related issues
No response
Are you willing to submit a PR?
- [ ] Yes I am willing to submit a PR!
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
For most of cases, users might use the same rules as shown, so I think maybe we can keep these rules. If users want to utilize their own rules, they will define by themselves, otherwise, why not give them default value?
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
However, it is quite confusing for users, they would get an unexpected result when they set the options to empty.
I added this to v0.15 and we should discuss this matter. @Startrekzky @yumengwang03
@warren830 I'm not against providing reasonable default values to users. But I think the key issue here is that the current frontend presentation would lead users to believe those values are just placeholders, instead of default values, thus resulting in the mismatch of the frontend and backend behavior.
If we keep the frontend unchanged, I will vote for removing those default values in the backend as well.
I agree with @hezyin and I created issue #3675 for providing reasonable default values. I need some time to finish the default values for each plugin though, and the default values should be shown in the Config UI form fields.
This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.
This issue has been closed because it has not received response for too long time. You could reopen it if you encountered similar problems in the future.