incubator-devlake icon indicating copy to clipboard operation
incubator-devlake copied to clipboard

[Feature][Config UI] About jenkins connections modularity.

Open mintsweet opened this issue 3 years ago • 6 comments

Search before asking

  • [X] I had searched in the issues and found no similar feature requirement.

Description

In my work, I need to constantly add new functions on the Config UI to our system, which is very painful for me, so I hope to be able to directly reference the Config UI to alleviate this repetitive work.

After some discussions today, we found that making the Config UI embeddable is a complicated thing, and it cannot be done in a short time, so we hope to use the Jenkins connection as an example to try to make This part becomes embeddable.

So I created this issue to try to do this.

Use case

Make Jenkins connection embeddable so I don't need to reimplement Config UI on my system.

Related issues

https://github.com/apache/incubator-devlake/issues/2241

Are you willing to submit a PR?

  • [X] Yes I am willing to submit a PR!

Code of Conduct

mintsweet avatar Sep 16 '22 07:09 mintsweet

@klesh @e2corporation

mintsweet avatar Sep 16 '22 07:09 mintsweet

Hi, @mintsweet , I agree that we can try it out and see if it is viable, and evaluate the ROI.

Would you mind to share your Plan of Attack? like creating a npm package for it, and using it in your project, step by step what do you plan to prove the concept? For example:

  1. Refactor Jinkens connection editing page as an independent component
  2. Move it to a specific folder, create a npm package for the folder
  3. Reuse the package in other projects
  4. Summarize the effort we have to put in, and the value we may have in future development

In general, we need to know your plan so we can collaborate, and we need a report to justify the direction we are heading is worthwhile.

klesh avatar Sep 19 '22 07:09 klesh

Hi, @klesh, this is my plan.

  1. Create a new directory config-ui-lib.(This directory contains all the development bases, and I have done this step).
  2. Create configuration related to Jenkins.
  3. Release-tested npm package of version 0.0.1-rc based on config-ui-lib.(This will be done by this week).
  4. Use the config-lib-ui package to integrate Jenkins into our system. (This will complete the trial by next week).
  5. If there is no problem with 4, I will make other connections like this. (It will take me a little more time).
  6. Finally I will use the new integrative config ui component to assemble the new page. (Then config-ui-lib will replace config-ui)

mintsweet avatar Sep 19 '22 07:09 mintsweet

Hi, @klesh, this is my plan.

  1. Create a new directory config-ui-lib.(This directory contains all the development bases, and I have done this step).
  2. Create configuration related to Jenkins.
  3. Release-tested npm package of version 0.0.1-rc based on config-ui-lib.(This will be done by this week).
  4. Use the config-lib-ui package to integrate Jenkins into our system. (This will complete the trial by next week).
  5. If there is no problem with 4, I will make other connections like this. (It will take me a little more time).
  6. Finally I will use the new integrative config ui component to assemble the new page. (Then config-ui-lib will replace config-ui)

Sounds good. I would like to confirm a few things:

  1. Are all these changes happening in your PoC Branch?
  2. Will you prepare a report for ROI evaluation?
  3. Do we agree that the PoC branch will be merged if and only if we reached a consensus?

klesh avatar Sep 19 '22 08:09 klesh

@klesh

  1. Yes.
  2. I need to think about it, maybe after finishing the first test I can give it.
  3. I don't know what counts as consensus.

mintsweet avatar Sep 20 '22 01:09 mintsweet

@klesh

  1. Yes.
  2. I need to think about it, maybe after finishing the first test I can give it.

Yeah, sure.

  1. I don't know what counts as consensus.

Please read the definition https://dictionary.cambridge.org/dictionary/english/consensus

klesh avatar Sep 22 '22 04:09 klesh

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Oct 23 '22 00:10 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Nov 24 '22 00:11 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Dec 27 '22 00:12 github-actions[bot]

This issue has been automatically marked as stale because it has not had recent activity for 30 days. It will be closed in next 7 days if no further activity occurs.

github-actions[bot] avatar Jan 27 '23 00:01 github-actions[bot]

this job stopped.

mintsweet avatar Jan 29 '23 03:01 mintsweet